Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Val: RDMA connection testing with pytest #326

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Val: RDMA connection testing with pytest #326

wants to merge 18 commits into from

Conversation

MateuszGrabuszynski
Copy link
Collaborator

@MateuszGrabuszynski MateuszGrabuszynski commented Feb 4, 2025 •
edited
Loading

Ready for review.

List of changes:

  • Add: Integrity checks allow for missing frames at the beginning and end /2/
  • Mod: media_proxy_dual() renamed to media_proxy_cluster() and filled with code to run media_proxies for cluster-based executions
  • Mod: Filenames for connection.json and client.json are now handled as variables, not hardcoded
  • Add: Type of test is detected based on logs (currently memif for local and rdma for cluster) and test is failed if wrong type is executed /1/
  • Add: Using a run() function, the optional env variables can optionally be passed with env variable.
  • Add: :doc: README has Virtual Functions, proxy and RDMA information
  • Add: Tests use media_info variable to pass media parameters to allow integrity checks
  • Mod: Unified imports (partially)

List of tasks:

  • Ensure RDMA connection is established in the background, instead of memif (check logs) /1/
  • Make the integrity test tolerate missing frames from the beginning (shifted start) /2/
  • Simplifying & cleanup (removing duplicates) - partially done, due to time constraints

@MateuszGrabuszynski
Add: not working sketch of RDMA tests
03ca2b1
@MateuszGrabuszynski
Add: Removal and listing of virtual functions, stub for RDMA; Fix: It…
653ae14 
…alics in hugepages description.
@MateuszGrabuszynski
Doc: add information about proxy settings
db21059
@MateuszGrabuszynski
Adding back media_proxy_single fixture in local test_video after swit…
1001287 
…ching to autouse=False
@MateuszGrabuszynski
(not working) MPG workaround for RDMA connection
92f89d3 
Add: modifiable json filenames in create_*_json functions
Fix: env variable MCM_MEDIA_PROXY_PORT takes string as dict value instead of int
Add: run_rx_tx_with_file() arguments for variable json filenames
Rem: TODO msg from kill_all_existing_media_proxies() as unnecessary
Add: media_proxy_cluster rdma parameters (ip, port)
Add: cluster test_video split rx and tx client json files
Workaround SDBQ-1949: cluster test_video uses MultipointGroup with urn to achieve RDMA connections
@MateuszGrabuszynski
Modify: Rescoping media_proxy_cluster to function to collect logs
880e405
@MateuszGrabuszynski
Improve: changing urn in connection to allow filtering logs with rdma
634ae9c
@MateuszGrabuszynski
Fix: client_cfg_file=connection_cfg_file issue
81532bd
@MateuszGrabuszynski
Mod: integrity.py::check_chunk_integrity() made more precise
9c8289a
@MateuszGrabuszynski
(not fully working) implementation of log filtering for connection ty…
76cf97f 
…pe detection
@MateuszGrabuszynski MateuszGrabuszynski marked this pull request as ready for review February 17, 2025 07:21
@MateuszGrabuszynski MateuszGrabuszynski changed the title Val: Adding pytest RDMA connection testing Val: RDMA connection testing with pytest Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwysock1-intel pwysock1-intel Awaiting requested review from pwysock1-intel pwysock1-intel is a code owner

@soopel soopel Awaiting requested review from soopel soopel is a code owner

@staszczuk staszczuk Awaiting requested review from staszczuk

@KarolinaPomian KarolinaPomian Awaiting requested review from KarolinaPomian

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MateuszGrabuszynski