fix:disable g2p

[JarbasAl]

reduce default LOG spam

companion to OpenVoiceOS/ovos-audio#109

Summary by CodeRabbit

• New Features

  • Enhanced wake word detection with multiple configurations for improved responsiveness.
  • Updated audio processing settings for better handling of silence and voice activity detection.

• Bug Fixes

  • Disabled the previous grapheme-to-phoneme module to streamline phoneme generation.

• Documentation

  • Retained and expanded documentation within the configuration file for clarity on settings and usage.

[coderabbitai]

Walkthrough

The pull request introduces extensive modifications to the mycroft.conf configuration file. Key changes include the disabling of the g2p module and its fallback, updates to the listener section for improved wake word detection and voice activity processing, and enhancements to the hotwords section with multiple configurations. The system section now restricts certain configuration changes, while the server and microservices sections detail backend and third-party API settings. These updates aim to restructure and enhance the configuration for better functionality.

Changes

File Path	Change Summary
ovos_config/mycroft.conf	- Disabled g2p module and fallback (set to empty string).
	- Updated listener section for wake word detection and audio processing.
	- Expanded hotwords section with multiple configurations.
	- Added constraints in system section to protect certain keys.
	- Specified backend configurations in server section.
	- Detailed third-party API settings in microservices section.

Possibly related PRs

• feat:fallback_plugins #153: The changes in this PR also involve modifications to the mycroft.conf file, specifically updating the G2P module and introducing fallback mechanisms, which aligns with the main PR's focus on restructuring the G2P section.
• fix:microphone default #155: This PR modifies the microphone settings in the mycroft.conf file, which is relevant as it also pertains to the overall configuration management and functionality improvements discussed in the main PR.
• fix:utterance filename #171: This PR updates the listener section of the mycroft.conf file, which is directly related to the changes made in the main PR regarding wake word detection and audio processing parameters.

Suggested reviewers

• goldyfruit
• mikejgray
• builderjer

🐰 In the meadow, changes bloom,
Configs shift, dispelling gloom.
Wake words dance, and silence fades,
New paths for voices, joy cascades.
With each tweak, our dreams take flight,
A brighter world, in sound and light! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between fd6e347 and 85e760c.

📒 Files selected for processing (1)

• ovos_config/mycroft.conf (1 hunks)

🧰 Additional context used

🔇 Additional comments (1)

ovos_config/mycroft.conf (1)

738-740: LGTM! Disabling g2p module reduces logging spam.

The change to disable the g2p (grapheme-to-phoneme) module by setting it to an empty string aligns with the PR objective to reduce default logging spam. This is safe as the module is only relevant for specific devices such as the Mark 1.

Let's verify if there are any Mark 1 specific configurations that might be affected:

✅ Verification successful

Let me try a different search strategy to verify the g2p module's usage and its relationship with Mark 1 devices.

---

Let me try one final search to specifically look for g2p module configurations:

---

Let me fix the regex syntax error:

---

Disabling g2p module is safe and aligns with deprecation plans

The verification reveals that the g2p module is part of a deprecated section that's being removed, as indicated by the comment right after the g2p configuration. Setting the module to an empty string is not only safe for reducing logging spam but also aligns with the ongoing deprecation process. The change won't impact Mark 1 devices negatively as this feature is already in the process of being fully removed from the codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for Mark 1 related configurations
rg -i "mark.?1|mark.?one" --type yaml --type json

Length of output: 51

---

Script:

#!/bin/bash
# Search for g2p configurations and related patterns
rg -i "g2p|grapheme|phoneme" --type yaml --type json -A 3 -B 3

Length of output: 2582

---

Script:

#!/bin/bash
# Search for g2p module configurations in the entire codebase
rg '"g2p":|"grapheme":|"g2p"\s*{' -A 5

Length of output: 160

---

Script:

#!/bin/bash
# Search for g2p module configurations in the entire codebase
rg '"g2p":' -A 5

Length of output: 330

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@fd6e347). Learn more about missing BASE report.

Additional details and impacted files

@@          Coverage Diff          @@
##             dev    #174   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      10           
  Lines          ?     877           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?     877           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.