Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sweden and norway #179

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

add sweden and norway #179

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1d5f22b
Danish added
andlo Nov 3, 2024
f877eb0
fix an error
andlo Nov 3, 2024
2a42ade
added swedish and nowegian
andlo Nov 4, 2024
fdc8350
mistake correction
andlo Nov 4, 2024
9d9d839
correct sv-seand no-no
andlo Nov 5, 2024
4ae8322
Merge branch 'OpenVoiceOS:dev' into dev
andlo Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ovos_config/locale.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ def get_full_lang_code(lang):
'hu': 'hu-hu',
'it': 'it-it',
'nl': 'nl-nl',
'no': 'no-no',
JarbasAl marked this conversation as resolved.
Show resolved Hide resolved
'pl': 'pl-pl',
'pt': 'pt-pt',
'ru': 'ru-ru',
Expand Down
9 changes: 9 additions & 0 deletions ovos_config/recommends/base/da-dk.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"system_unit": "metric",
"temperature_unit": "celsius",
"windspeed_unit": "km/h",
"precipitation_unit": "mm",
"time_format": "full",
"spoken_time_format": "full",
"date_format": "DMY"
}
9 changes: 9 additions & 0 deletions ovos_config/recommends/base/no-no.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"system_unit": "metric",
"temperature_unit": "celsius",
"windspeed_unit": "km/h",
"precipitation_unit": "mm",
"time_format": "full",
"spoken_time_format": "full",
"date_format": "DMY"
}
9 changes: 9 additions & 0 deletions ovos_config/recommends/base/sv-se.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"system_unit": "metric",
"temperature_unit": "celsius",
"windspeed_unit": "km/h",
"precipitation_unit": "mm",
"time_format": "full",
"spoken_time_format": "full",
"date_format": "YMD"
}
8 changes: 8 additions & 0 deletions ovos_config/recommends/offline_male/da-dk.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"tts": {
"module": "ovos-tts-plugin-piper",
"ovos-tts-plugin-piper": {
"voice": "nst_talesyntese-medium"
}
}
}
8 changes: 8 additions & 0 deletions ovos_config/recommends/offline_male/no-no.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"tts": {
"module": "ovos-tts-plugin-piper",
"ovos-tts-plugin-piper": {
"voice": "nst_talesyntese-medium"
}
}
}
8 changes: 8 additions & 0 deletions ovos_config/recommends/offline_male/se-sv.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"tts": {
"module": "ovos-tts-plugin-piper",
"ovos-tts-plugin-piper": {
"voice": "nst_talesyntese-medium"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Inappropriate voice model for Swedish TTS.

The configuration uses "nst_talesyntese-medium" which appears to be a Norwegian voice model (NST = Norsk Språkteknologi). This is inappropriate for Swedish text-to-speech.

Please use an appropriate Swedish voice model. Common Swedish voices available in Piper include:

  • "talesyntese_sv_se_nst-medium"
  • "sv_se_nst_medium"

Example configuration:

  "ovos-tts-plugin-piper": {
-    "voice": "nst_talesyntese-medium"
+    "voice": "talesyntese_sv_se_nst-medium"
  }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"ovos-tts-plugin-piper": {
"voice": "nst_talesyntese-medium"
}
"ovos-tts-plugin-piper": {
"voice": "talesyntese_sv_se_nst-medium"
}

}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Incorrect language code in filename.

The filename uses "se-sv" which is incorrect for Swedish. The ISO 639-1/ISO 3166-1 language code for Swedish (Sweden) should be "sv-SE". The file should be renamed accordingly.

Rename the file from se-sv.conf to sv-SE.conf.

9 changes: 9 additions & 0 deletions ovos_config/recommends/offline_stt/da-dk.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"stt": {
"module": "ovos-stt-plugin-fasterwhisper",
"fallback_module": "",
"ovos-stt-plugin-fasterwhisper": {
"model": "small"
}
}
}
9 changes: 9 additions & 0 deletions ovos_config/recommends/offline_stt/no-no.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"stt": {
"module": "ovos-stt-plugin-fasterwhisper",
"fallback_module": "",
"ovos-stt-plugin-fasterwhisper": {
"model": "small"
}
}
}
9 changes: 9 additions & 0 deletions ovos_config/recommends/offline_stt/sv-se.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"stt": {
"module": "ovos-stt-plugin-fasterwhisper",
"fallback_module": "",
"ovos-stt-plugin-fasterwhisper": {
"model": "small"
}
}
}
8 changes: 8 additions & 0 deletions ovos_config/recommends/online_male/da-dk.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"tts": {
"module": "ovos-tts-plugin-server",
"ovos-tts-plugin-server": {
"voice": "nst_talesyntese-medium"
}
}
}
8 changes: 8 additions & 0 deletions ovos_config/recommends/online_male/no-no.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"tts": {
"module": "ovos-tts-plugin-server",
"ovos-tts-plugin-server": {
"voice": "nst_talesyntese-medium"
}
}
}
8 changes: 8 additions & 0 deletions ovos_config/recommends/online_male/sv-se.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"tts": {
"module": "ovos-tts-plugin-server",
"ovos-tts-plugin-server": {
"voice": "nst_talesyntese-medium"
}
}
}
6 changes: 6 additions & 0 deletions ovos_config/recommends/online_stt/da-dk.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"stt": {
"module": "ovos-stt-plugin-server",
"fallback_module": ""
}
}
6 changes: 6 additions & 0 deletions ovos_config/recommends/online_stt/no-no.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"stt": {
"module": "ovos-stt-plugin-server",
"fallback_module": ""
}
}
Loading