deprecate:backend client

[JarbasAl]

Summary by CodeRabbit

• New Features

  • Simplified configuration management by removing deprecated remote functions.
  • Updated documentation for the RemoteConf class to clarify its purpose.
  • Streamlined the mycroft.conf configuration by removing unnecessary settings related to data collection and skill management.

• Bug Fixes

  • Eliminated potential errors related to remote configuration fetching by removing the reload method.
  • Enhanced user privacy by removing the opt_in setting and related keys from the configuration.

• Chores

  • Removed the requirements/extras.txt file and its dependencies.
  • Updated the requirements/tests.txt file by removing several dependencies and adjusting version constraints.
  • Simplified the package setup by removing the extras_require parameter from setup.py.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve the removal of three deprecated functions (is_remote_list, translate_remote, and translate_list) from the ovos_config/models.py file, along with the removal of the reload method from the RemoteConf class. The docstring for the RemoteConf class was updated to clarify its role as a configuration dictionary managed by an external service. Additionally, the mycroft.conf configuration file underwent significant modifications, including the removal of several settings related to data collection, skill management, and server configurations, streamlining the overall configuration. The requirements/extras.txt file was deleted, and several dependencies were removed or updated in requirements/tests.txt. Lastly, the extras_require parameter was removed from setup.py.

Changes

File	Change Summary
ovos_config/models.py	Removed methods: is_remote_list, translate_remote, translate_list, and reload. Updated docstring for RemoteConf.
ovos_config/mycroft.conf	Removed settings: "opt_in", "upload_skill_manifest", "sync2way", "autogen_meta". Removed key from protected keys: "opt_in". Entire section removed: "server".
requirements/extras.txt	Deleted file; removed dependency: ovos-backend-client>=0.1.0,<2.0.0.
requirements/tests.txt	Removed dependencies: sphinx==2.2.1, sphinx-rtd-theme==0.4.3, mock_msm~=0.9.2, ovos-stt-plugin-vosk>=0.1.3, python-vlc==1.1.2. Updated: ovos-bus-client version constraint changed from ~=0.0.8 to <2.0.0.
setup.py	Removed extras_require parameter from setup().

Possibly related PRs

• deprecate:backend client #183: This PR directly relates to the main PR as it involves the removal of the same deprecated functions (is_remote_list, translate_remote, translate_list) and the reload method from the RemoteConf class in ovos_config/models.py, indicating a significant overlap in changes made to the same code elements.

Suggested reviewers

• NeonDaniel

🐰 "In the code, a change took flight,
Functions deprecated, now out of sight.
With a hop and a skip, we simplify,
Remote confs managed, oh my, oh my!
A clearer path, a lighter load,
Onward we go, down the coding road!" 🐇

Warning

Rate limit exceeded

@JarbasAl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 52 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 1aef456 and 2f54af0.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@fab4527). Learn more about missing BASE report.

Additional details and impacted files

@@          Coverage Diff          @@
##             dev    #183   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      10           
  Lines          ?     837           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?     837           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests