Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remote config reload #74

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

emphasize
Copy link
Member

  • set and store remote config (keys) only when changed
  • more verbose debug logging to see what has changed
  • import FileWatcher from ovos_utils.file_utils (ovos_config.utils deprecated)

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@bece0cf). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev     #74   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      10           
  Lines          ?     810           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?     810           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl added the bug Something isn't working label Sep 18, 2023
@JarbasAl JarbasAl merged commit 8232d00 into OpenVoiceOS:dev Sep 18, 2023
7 checks passed
@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants