feat/runtime skill installer #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev #347 +/- ##
==========================================
- Coverage 50.35% 44.16% -6.20%
==========================================
Files 119 13 -106
Lines 10077 1764 -8313
==========================================
- Hits 5074 779 -4295
+ Misses 5003 985 -4018 ☔ View full report in Codecov by Sentry. |
JarbasAl
requested review from
goldyfruit,
ChanceNCounter,
mikejgray,
NeonDaniel and
a team
mikejgray
reviewed
Sep 17, 2023
mikejgray
requested changes
Sep 19, 2023
There was a problem hiding this comment.
Tested with the below JSON using mana send-message-file. Everything seemed to work just fine except for pip uninstall. Please validate? Also I found an incorrect message type.
{
"msg_type": "ovos.pip.install",
"data": {"packages": ["spongebobify"]},
"context": {}
}
{
"msg_type": "ovos.skills.install",
"data": {"url": "https://github.com/OpenVoiceOS/skill-ovos-parrot"},
"context": {}
}
{
"msg_type": "ovos.pip.uninstall",
"data": {"packages": ["spongebobify"]},
"context": {}
}
{
"msg_type": "ovos.skills.uninstall",
"data": {"url": "https://github.com/OpenVoiceOS/skill-ovos-parrot"},
"context": {}
}
mikejgray
requested changes
Sep 19, 2023
There was a problem hiding this comment.
Still doesn't seem to uninstall:
ovos@mark1-dev:~ $ cat uninstall_pip.json
{
"msg_type": "ovos.pip.uninstall",
"data": {"packages": ["spongebobify"]},
"context": {}
}
ovos@mark1-dev:~ $ mana send-message-file ~/uninstall_pip.json
Message Sent
ovos@mark1-dev:~ $ tail -f ~/.local/state/mycroft/bus.log | grep uninstall
2023-09-19 10:58:44.689 - bus - ovos_messagebus.event_handler:on_message:37 - DEBUG - {"type": "ovos.pip.uninstall", "data": {"packages": ["spongebobify"]}, "context": {"client_name": "mana", "client": "mana", "source": ["mana"]}}
^C
ovos@mark1-dev:~ $ pip list | grep spongebobify
spongebobify 0.1.2
ovos@mark1-dev:~ $ tail -f ~/.local/state/mycroft/bus.log | grep uninstall
^C
ovos@mark1-dev:~ $ pip list | grep spongebobify
spongebobify 0.1.2
|
Codecov is extremely unhappy! Wow that’s a lot of lines. I just wanna confirm that it is working correctly on this repo, and this PR really does represent a 6.22% coverage decrease. That ain’t great. |
no it's not |
|
all seems to be working for me |
|
I've confirmed at least the happy path for each new bus message works. Only thing missing are some tests. Also, is it deliberate that core doesn't test Python > 3.9? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow installing skills via messagebus
does not use OSM, tested with https://github.com/OpenVoiceOS/ovos-audio-transformer-plugin-ggwave