Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/2-letter-langcode-handling #381

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Dec 7, 2023

companion to OpenVoiceOS/ovos-config#85

fix #380

@JarbasAl JarbasAl added the bug Something isn't working label Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8e947fc) 60.90% compared to head (44a3f4a) 60.90%.
Report is 1 commits behind head on dev.

Files Patch % Lines
ovos_core/intent_services/__init__.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #381   +/-   ##
=======================================
  Coverage   60.90%   60.90%           
=======================================
  Files          13       13           
  Lines        1857     1857           
=======================================
  Hits         1131     1131           
  Misses        726      726           
Flag Coverage Δ
unittests 60.90% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit d6a706c into dev Dec 15, 2023
10 checks passed
@JarbasAl JarbasAl deleted the fix/2-letter-langcode-handling branch December 15, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignoring stt_lang, en is not in enabled languages: ['fr-fr', 'fr-fr', 'en-us']
1 participant