-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add adapt match levels #402
Conversation
the rest of the failing unittest should go back to the config defaults in |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #402 +/- ##
==========================================
+ Coverage 62.72% 63.49% +0.77%
==========================================
Files 14 14
Lines 2039 2063 +24
==========================================
+ Hits 1279 1310 +31
+ Misses 760 753 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Works for me! |
edge case when config is missing / older ovos-config installed sync with OpenVoiceOS/ovos-core#402
edge case when config is missing / older ovos-config installed sync with OpenVoiceOS/ovos-core#402
Problem: The Adapt matcher matching unrestricted.
As with the other services, 3 (configurable) threshold matcher are added to the pipeline for finegrained adjustability.
One thing in question, is the config option (key
context
) what we want?Companion PR (config): OpenVoiceOS/ovos-config#100