Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) personal news with possibility of creating a single page that … #34

Open
wants to merge 67 commits into
base: mijn-zaken/frontend
Choose a base branch
from
Open

(feat) personal news with possibility of creating a single page that … #34

wants to merge 67 commits into from

Conversation

Jikizuari
Copy link
Collaborator

…gets content filled through OpenPub API

Notes

  • For the news detail page you'd have to create an empty singular page. The content gets filled in based on the HW website selectors with the assumption that the classnames/selectors are identical on other websites. (quite a scary one but I'll take the risk)
  • The API URL and stuff are stored in LocalStorage because the API URL is entered in the Gutenberg block. I'd prefer to see this as a theme option but the requirement was that the URL was entered in the Gutenberg block.

Questions

  • Postcode is currently hard coded. @YvetteNikolov or @mvdhoek1 , is there currently a way to get the current user's postcode (my guess would be BRP? If yes, what's -the- way before I dive into it or potentially build something that already exists)

YvetteNikolov and others added 30 commits November 27, 2023 14:15
@YvetteNikolov @robertbossaert
(feat): first setup of hw navbar and footer
02970fa
@YvetteNikolov @robertbossaert
(chore): add dev branch of owc-gravityforms-zaaksysteem for demo
93df1b5
@YvetteNikolov @robertbossaert
(refractor): centralize mijn zaken templates to parent theme
a40cdda
@YvetteNikolov @robertbossaert
(chore): update gravityforms zaak plugin
9393ea7
@YvetteNikolov @robertbossaert
(chore): merge files from feature/openpdd-sidebar-template
bbdf948
@YvetteNikolov @robertbossaert
(chore): temporarily slightly change sidebar of mijn-zaken
61c822f
@YvetteNikolov @robertbossaert
(chore): add menus to bar child themes
485787c
@YvetteNikolov @robertbossaert
(fix): check on mijn-zaken nav menu
058c28f
@GijsvanArem @robertbossaert
(feat): add blocks
24776ce
@YvetteNikolov @robertbossaert
(feat): first setup of hw navbar and footer
e1eda20
@YvetteNikolov @robertbossaert
(refractor): centralize mijn zaken templates to parent theme
8e8efbe
@YvetteNikolov @robertbossaert
(chore): merge files from feature/openpdd-sidebar-template
b029ce6
@YvetteNikolov @robertbossaert
(chore): temporarily slightly change sidebar of mijn-zaken
f18f53a
@YvetteNikolov @robertbossaert
(chore): update composer.lock
8971441
@YvetteNikolov @robertbossaert
(feat): first setup of hw navbar and footer
627b9dc
@YvetteNikolov @robertbossaert
(refractor): centralize mijn zaken templates to parent theme
849afbc
@YvetteNikolov @robertbossaert
(chore): merge files from feature/openpdd-sidebar-template
200da3b
@YvetteNikolov @robertbossaert
(chore): temporarily slightly change sidebar of mijn-zaken
bca8135
@YvetteNikolov @robertbossaert
(style): improve link underline styling
56e76f9
@YvetteNikolov @robertbossaert
(style): buren mijn-zaken footer columns
f2b980e
@YvetteNikolov @robertbossaert
(chore): several small scss adjustments
3e64898
@YvetteNikolov @robertbossaert
(chore): run prettier and enforce stylelint rules
6683f8f
@YvetteNikolov @robertbossaert
(chore): several small scss adjustments
9ab62f5
@YvetteNikolov @robertbossaert
(style): fix mijn-zaken template-columns
16f7e20
@YvetteNikolov @robertbossaert
(chore): css variables
17efa47
@YvetteNikolov @robertbossaert
(chore): add template-mijn-zaken-main
d511392
@YvetteNikolov @robertbossaert
(chore): add custom sidebar for buren
8e7c248
@robertbossaert
(chore): composer update
d62212f
@YvetteNikolov @robertbossaert
(chore): add bar theme
43a2b7e
@YvetteNikolov @robertbossaert
(chore): add gouda theme
e72532e
mvdhoek1
mvdhoek1 reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@mvdhoek1 mvdhoek1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoi Gijs,

JS en SCSS is niet mijn area of expertise maar voor zover ik kan zeggen ziet het er goed uit. Betreft je vraag over het ophalen van de postcode. Mijn college Simon is bezig met een Gutenberg blok voor het ophalen van gegevens uit de BRP. Misschien heb je daar wat aan. Laten we dit checken tijdens het aankomende fieldlab.

@mvdhoek1 mvdhoek1 force-pushed the mijn-zaken/frontend branch 3 times, most recently from 5c9e055 to 412bd7e Compare January 8, 2024 15:14
YvetteNikolov
YvetteNikolov reviewed Jan 22, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
YvetteNikolov
YvetteNikolov reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@YvetteNikolov YvetteNikolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er goed uit :)

Ook bij deze graag de controls naar de InspectorControl sidebar. Voor de content kun je een <Placeholder/> component o.i.d. gebruiken waarin wordt uitgelegd dat het persoonlijk nieuws aan de voorkant gerendered wordt.

YvetteNikolov
YvetteNikolov reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@YvetteNikolov YvetteNikolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Laat het vooral weten als je een update hebt gedaan. Dan kijk ik er nog een keer naar en approve 'm.

@Jikizuari
Copy link
Collaborator Author

@YvetteNikolov PR feedback is verwerkt :-)

@mvdhoek1 mvdhoek1 force-pushed the mijn-zaken/frontend branch 4 times, most recently from 82f6f58 to 3c9841c Compare January 30, 2024 09:16
YvetteNikolov
YvetteNikolov reviewed Feb 1, 2024
View reviewed changes
htdocs/wp-content/themes/owc-formulieren/assets/js/editor/news/edit.js
'(\\?[;&a-z\\d%_.~+=-]*)?' + // validate query string
'(\\#[-a-z\\d_]*)?$', 'i' ); // validate fragment locator
return !!urlPattern.test( urlString );
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deze wat mag mij betreft in assets/js/editor/util/helpers.js. Dan is hij vaker inzetbaar en testbaar.

YvetteNikolov
YvetteNikolov approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@YvetteNikolov YvetteNikolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Het mag gemerged woden. Wordt in de toekomst een refractor naar een SSR block, maar fijn om dit alvast in het project te hebben.

@mvdhoek1 mvdhoek1 force-pushed the mijn-zaken/frontend branch 2 times, most recently from fdc044c to a726a42 Compare February 8, 2024 07:23
@mvdhoek1 mvdhoek1 force-pushed the mijn-zaken/frontend branch from 09105dc to 6b5b9ef Compare February 26, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdhoek1 mvdhoek1 mvdhoek1 left review comments

@YvetteNikolov YvetteNikolov YvetteNikolov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jikizuari @mvdhoek1 @YvetteNikolov @GijsvanArem @robertbossaert @SimonvanWijhe