Update WmlToHtmlConverter.cs #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbetts
reviewed
Oct 1, 2023
| @@ -528,7 +608,7 @@ private static object ProcessHyperlinkToBookmark(WordprocessingDocument wordDoc, | |||
| { | |||
| var style = new Dictionary<string, string>(); | |||
| var a = new XElement(Xhtml.a, | |||
| new XAttribute("href", "#" + (string) element.Attribute(W.anchor)), | |||
| new XAttribute("href", "#" + (string)element.Attribute(W.anchor)), | |||
There was a problem hiding this comment.
There's a lot of formatting/style changes that should be reverted, since they only make the PR harder to review.
danbetts
reviewed
Oct 1, 2023
| @@ -439,7 +509,17 @@ private static void SetStyleElementValue(XElement xhtml, string styleValue) | |||
| // Transform contents of runs. | |||
| if (element.Name == W.r) | |||
| { | |||
| return ConvertRun(wordDoc, settings, element); | |||
| //return ConvertRun(wordDoc, settings, element); | |||
There was a problem hiding this comment.
This is where the PR falls over. An earlier PR changes this particular bit of code.
huan086
pushed a commit
to huan086/Open-Xml-PowerTools
that referenced
this pull request
Sep 17, 2024
Eric white dev v next
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.