remove tests that check caller is not the zero address

OpenZeppelin · Nov 18, 2024 · 94ad425 · 94ad425
1 parent f4a41ba
commit 94ad425
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 64 deletions.
diff --git a/packages/access/src/ownable/ownable.cairo b/packages/access/src/ownable/ownable.cairo
@@ -63,7 +63,6 @@ pub mod OwnableComponent {
     pub mod Errors {
         pub const NOT_OWNER: felt252 = 'Caller is not the owner';
         pub const NOT_PENDING_OWNER: felt252 = 'Caller is not the pending owner';
-        pub const ZERO_ADDRESS_CALLER: felt252 = 'Caller is the zero address';
         pub const ZERO_ADDRESS_OWNER: felt252 = 'New owner is the zero address';
     }
 

diff --git a/packages/access/src/tests/test_ownable.cairo b/packages/access/src/tests/test_ownable.cairo
@@ -63,13 +63,6 @@ fn test_assert_only_owner_when_not_owner() {
     state.assert_only_owner();
 }
 
-#[test]
-#[should_panic(expected: ('Caller is the zero address',))]
-fn test_assert_only_owner_when_caller_zero() {
-    let state = setup();
-    state.assert_only_owner();
-}
-
 //
 // _transfer_ownership
 //
@@ -124,13 +117,6 @@ fn test_transfer_ownership_to_zero() {
     state.transfer_ownership(ZERO());
 }
 
-#[test]
-#[should_panic(expected: ('Caller is the zero address',))]
-fn test_transfer_ownership_from_zero() {
-    let mut state = setup();
-    state.transfer_ownership(OTHER());
-}
-
 #[test]
 #[should_panic(expected: ('Caller is not the owner',))]
 fn test_transfer_ownership_from_nonowner() {
@@ -159,13 +145,6 @@ fn test_transferOwnership_to_zero() {
     state.transferOwnership(ZERO());
 }
 
-#[test]
-#[should_panic(expected: ('Caller is the zero address',))]
-fn test_transferOwnership_from_zero() {
-    let mut state = setup();
-    state.transferOwnership(OTHER());
-}
-
 #[test]
 #[should_panic(expected: ('Caller is not the owner',))]
 fn test_transferOwnership_from_nonowner() {
@@ -190,13 +169,6 @@ fn test_renounce_ownership() {
     assert!(state.owner().is_zero());
 }
 
-#[test]
-#[should_panic(expected: ('Caller is the zero address',))]
-fn test_renounce_ownership_from_zero_address() {
-    let mut state = setup();
-    state.renounce_ownership();
-}
-
 #[test]
 #[should_panic(expected: ('Caller is not the owner',))]
 fn test_renounce_ownership_from_nonowner() {
@@ -217,13 +189,6 @@ fn test_renounceOwnership() {
     assert!(state.owner().is_zero());
 }
 
-#[test]
-#[should_panic(expected: ('Caller is the zero address',))]
-fn test_renounceOwnership_from_zero_address() {
-    let mut state = setup();
-    state.renounceOwnership();
-}
-
 #[test]
 #[should_panic(expected: ('Caller is not the owner',))]
 fn test_renounceOwnership_from_nonowner() {

diff --git a/packages/access/src/tests/test_ownable_twostep.cairo b/packages/access/src/tests/test_ownable_twostep.cairo
@@ -96,13 +96,6 @@ fn test_transfer_ownership_to_zero() {
     assert_eq!(state.pending_owner(), ZERO());
 }
 
-#[test]
-#[should_panic(expected: ('Caller is the zero address',))]
-fn test_transfer_ownership_from_zero() {
-    let mut state = setup();
-    state.transfer_ownership(OTHER());
-}
-
 #[test]
 #[should_panic(expected: ('Caller is not the owner',))]
 fn test_transfer_ownership_from_nonowner() {
@@ -144,13 +137,6 @@ fn test_transferOwnership_to_zero() {
     assert!(state.pendingOwner().is_zero());
 }
 
-#[test]
-#[should_panic(expected: ('Caller is the zero address',))]
-fn test_transferOwnership_from_zero() {
-    let mut state = setup();
-    state.transferOwnership(OTHER());
-}
-
 #[test]
 #[should_panic(expected: ('Caller is not the owner',))]
 fn test_transferOwnership_from_nonowner() {
@@ -244,13 +230,6 @@ fn test_renounce_ownership_resets_pending_owner() {
     assert!(current_pending_owner.is_zero());
 }
 
-#[test]
-#[should_panic(expected: ('Caller is the zero address',))]
-fn test_renounce_ownership_from_zero_address() {
-    let mut state = setup();
-    state.renounce_ownership();
-}
-
 #[test]
 #[should_panic(expected: ('Caller is not the owner',))]
 fn test_renounce_ownership_from_nonowner() {
@@ -272,13 +251,6 @@ fn test_renounceOwnership() {
     assert!(state.owner().is_zero());
 }
 
-#[test]
-#[should_panic(expected: ('Caller is the zero address',))]
-fn test_renounceOwnership_from_zero_address() {
-    let mut state = setup();
-    state.renounceOwnership();
-}
-
 #[test]
 #[should_panic(expected: ('Caller is not the owner',))]
 fn test_renounceOwnership_from_nonowner() {