-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Refactor pausable for erc721 example #414
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for contracts-stylus canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am against those changes as they are NOT consistent with our examples.
If we want to merge this PR, also all the rust docs should be updated where needed.
@qalisander @ggonzalez94 wdyt?
@0xNeshi Pausable doesn't work this way alas. In this case Also It's been attempt before to implement Pausable with different approach. But it involves more code duplication.. |
I see what I missed. Technically you're calling |
@qalisander @bidzyyys ahh, life without multi-inheritance is such a pain 😔 The more I look at this code, the more I like the original design. If a dev wants to make a pausable ERC721, they should inherit both erc721 and Pausable, and reimplement all the functions they want to make pausable to just call Maybe we just close this PR and leave things as-is until multi-inheritance is properly supported, what do you guys think? |
Resolves #212