Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed upload job limiter #386

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ferishili
Copy link
Contributor

This PR fixes #385,

What is new

  • New Setting: in shared setting -> "Limit failed upload attempts"
  • Notify teachers if "eventstatusnotificationenabled" is enabled.
  • Puts the uploadjob into the “Archived” state when the failed upload limit is reached.
  • Teachers are able to:
    • Delete archived uploadjob from the table
    • (NEW) Unarchived Icon "reload icon" is provided right beside the delete icon in the upload job list. This brings back the archived uploadjob to the initial state "Ready to upload" in order to force the cron to pick it up in the next run! aka "unarchive"

@ferishili
Copy link
Contributor Author

There is currently a failure in upstream of moodle-plugin-ci which causes the GitHub actions to fail:

Opencast-Moodle/moodle-workflows-opencast#5

@tmtsc
Copy link

tmtsc commented Aug 30, 2024

It works!

Copy link
Collaborator

@justusdieckmann justusdieckmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks great to me! Apart from the notification stuff, I only have one wish/suggestion: Moodle strongly discourages the use of jQuery in new Code, so if you have the time, it would be great to use native JS instead of jQuery in new Code. But we'll have to go through the javascript code anyway someday and replace all the jQuery, so I would also merge it if you don't do that.

lang/en/block_opencast.php Outdated Show resolved Hide resolved
renderer.php Outdated Show resolved Hide resolved
@ferishili
Copy link
Contributor Author

Thank you, this looks great to me! Apart from the notification stuff, I only have one wish/suggestion: Moodle strongly discourages the use of jQuery in new Code, so if you have the time, it would be great to use native JS instead of jQuery in new Code. But we'll have to go through the javascript code anyway someday and replace all the jQuery, so I would also merge it if you don't do that.

Hi @justusdieckmann, thanks for your review.
I have added the changes and answered your question regarding redundant teacher notification.

About the JS and JQuery, I would say, because it is a part of index js file, therefore, it gets a bit messy if I change it to js now, and that would be great, if we could take care of it later on in one single go! Regarding this, I provided new es6 js for my new PR but in here, it is not feasible!

BR

@ferishili
Copy link
Contributor Author

Hi @justusdieckmann;
thanks for your review, is there something left to do here, or we could get it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid retrying faulty uploads when upload job process throws error
3 participants