address feedback

Opentrons · May 7, 2024 · 0a95bab · 0a95bab
1 parent 586728e
commit 0a95bab
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/app/src/atoms/MenuList/DropdownMenu.tsx b/app/src/atoms/MenuList/DropdownMenu.tsx
@@ -74,7 +74,7 @@ export function DropdownMenu(props: DropdownMenuProps): JSX.Element {
       const dropdownRect = dropDownMenuWrapperRef.current?.getBoundingClientRect()
       if (dropdownRect != null) {
         const parentElement = dropDownMenuWrapperRef?.current?.parentElement
-        const grandParentElement = parentElement?.parentElement
+        const grandParentElement = parentElement?.parentElement?.parentElement
         let availableHeight = window.innerHeight
         let scrollOffset = 0
 
@@ -91,12 +91,7 @@ export function DropdownMenu(props: DropdownMenuProps): JSX.Element {
         const dropdownBottom =
           dropdownRect.bottom + (filterOptions.length + 1) * 34 - scrollOffset
 
-        setDropdownPosition(
-          dropdownBottom > availableHeight &&
-            window.innerHeight < availableHeight
-            ? 'top'
-            : 'bottom'
-        )
+        setDropdownPosition(dropdownBottom > availableHeight ? 'top' : 'bottom')
       }
     }