rearrange imports, remove console log

Opentrons · Apr 2, 2024 · 60b8de0 · 60b8de0
1 parent 3011baa
commit 60b8de0
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/app/src/organisms/ChooseProtocolSlideout/index.tsx b/app/src/organisms/ChooseProtocolSlideout/index.tsx
@@ -48,10 +48,10 @@ import { useCreateRunFromProtocol } from '../ChooseRobotToRunProtocolSlideout/us
 import { ApplyHistoricOffsets } from '../ApplyHistoricOffsets'
 import { useOffsetCandidatesForAnalysis } from '../ApplyHistoricOffsets/hooks/useOffsetCandidatesForAnalysis'
 import { getAnalysisStatus } from '../ProtocolsLanding/utils'
+import type { RunTimeParameter } from '@opentrons/shared-data'
 import type { Robot } from '../../redux/discovery/types'
 import type { StoredProtocolData } from '../../redux/protocol-storage'
 import type { State } from '../../redux/types'
-import type { RunTimeParameter } from '@opentrons/shared-data'
 
 export const CARD_OUTLINE_BORDER_STYLE = css`
   border-style: ${BORDERS.styleSolid};
@@ -78,20 +78,22 @@ export function ChooseProtocolSlideoutComponent(
   const { t } = useTranslation(['device_details', 'shared'])
   const history = useHistory()
   const logger = useLogger(new URL('', import.meta.url).pathname)
+  const [targetProps, tooltipProps] = useHoverTooltip()
+
   const { robot, showSlideout, onCloseClick } = props
   const { name } = robot
 
   const [
     selectedProtocol,
     setSelectedProtocol,
   ] = React.useState<StoredProtocolData | null>(null)
-  // todo (nd:04/01/2024) look at analysis instead of mock data for RTP
-  // const runTimeParameters =
-  //   selectedProtocol?.mostRecentAnalysis?.runTimeParameters ?? []
   const [
     runTimeParametersOverrides,
     setRunTimeParametersOverrides,
   ] = React.useState<RunTimeParameter[]>([])
+  const [currentPage, setCurrentPage] = React.useState<number>(1)
+  const enableRunTimeParametersFF = useFeatureFlag('enableRunTimeParameters')
+
   React.useEffect(() => {
     setRunTimeParametersOverrides(
       selectedProtocol?.mostRecentAnalysis?.runTimeParameters ?? []
@@ -100,15 +102,9 @@ export function ChooseProtocolSlideoutComponent(
   const runTimeParametersFromAnalysis =
     selectedProtocol?.mostRecentAnalysis?.runTimeParameters ?? []
 
-  const [currentPage, setCurrentPage] = React.useState<number>(1)
-  const enableRunTimeParametersFF = useFeatureFlag('enableRunTimeParameters')
   const hasRunTimeParameters =
     enableRunTimeParametersFF && runTimeParametersFromAnalysis.length > 0
 
-  const [targetProps, tooltipProps] = useHoverTooltip()
-
-  console.log(runTimeParametersOverrides)
-
   const analysisStatus = getAnalysisStatus(
     false,
     selectedProtocol?.mostRecentAnalysis
@@ -165,7 +161,14 @@ export function ChooseProtocolSlideoutComponent(
           location,
           definitionUri,
         }))
-      : []
+      : [],
+    runTimeParametersOverrides.reduce(
+      (acc, param) =>
+        param.value !== param.default
+          ? { ...acc, [param.variableName]: param.value }
+          : acc,
+      {}
+    )
   )
   const handleProceed: React.MouseEventHandler<HTMLButtonElement> = () => {
     if (selectedProtocol != null) {