Skip to content

Commit

Permalink
fix(protocol-designer): fix move step form title (#16883)
Browse files Browse the repository at this point in the history
fix RQA-3406

<!--
Thanks for taking the time to open a Pull Request (PR)! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:


https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

GitHub provides robust markdown to format your PR. Links, diagrams,
pictures, and videos along with text formatting make it possible to
create a rich and informative PR. For more information on GitHub
markdown, see:


https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

# Overview

<!--
Describe your PR at a high level. State acceptance criteria and how this
PR fits into other work. Link issues, PRs, and other relevant resources.
-->

changing "move labware" to "move" in step form and addStepOverflow menu.

## Test Plan and Hands on Testing

<!--
Describe your testing of the PR. Emphasize testing not reflected in the
code. Attach protocols, logs, screenshots and any other assets that
support your testing.
-->

## Changelog

<!--
List changes introduced by this PR considering future developers and the
end user. Give careful thought and clear documentation to breaking
changes.
-->

## Review requests

<!--
- What do you need from reviewers to feel confident this PR is ready to
merge?
- Ask questions.
-->

## Risk assessment

<!--
- Indicate the level of attention this PR needs.
- Provide context to guide reviewers.
- Discuss trade-offs, coupling, and side effects.
- Look for the possibility, even if you think it's small, that your
change may affect some other part of the system.
- For instance, changing return tip behavior may also change the
behavior of labware calibration.
- How do your unit tests and on hands on testing mitigate this PR's
risks and the risk of future regressions?
- Especially in high risk PRs, explain how you know your testing is
enough.
-->

---------

Co-authored-by: shiyaochen <[email protected]>
  • Loading branch information
syao1226 and shiyaochen authored Nov 19, 2024
1 parent 05eeed7 commit 8ed0043
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"heaterShaker": "heater-shaker",
"magnet": "magnet",
"mix": "mix",
"moveLabware": "move labware",
"moveLabware": "move",
"moveLiquid": "transfer",
"pause": "pause",
"profile_settings": "profile settings",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe('StepCreationButton', () => {
const addStep = screen.getByRole('button', { name: '+ Add Step' })
fireEvent.click(addStep)
screen.getByText('comment')
screen.getByText('move labware')
screen.getByText('move')
screen.getByText('transfer')
screen.getByText('mix')
screen.getByText('pause')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ describe('ConnectedStepItem', () => {
vi.mocked(getSelectedStepId).mockReturnValue(moveLabwareStepId)
props.stepId = moveLabwareStepId
render(props)
screen.getByText('2. move labware')
screen.getByText('2. move')
screen.getByText('Manually')
screen.getByText('labware')
screen.getByText('new location')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const getStepType = (stepType: StepType): string => {
return 'heater-shaker'
}
case 'moveLabware': {
return 'move labware'
return 'move'
}
case 'moveLiquid': {
return 'transfer'
Expand Down

0 comments on commit 8ed0043

Please sign in to comment.