Skip to content

Commit

Permalink
fix missing argument
Browse files Browse the repository at this point in the history
  • Loading branch information
shiyaochen authored and shiyaochen committed Aug 2, 2024
1 parent 91730fe commit f233d0e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 0 additions & 2 deletions robot-server/robot_server/persistence/tables/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
action_table,
run_csv_rtp_table,
data_files_table,
run_csv_rtp_table,
PrimitiveParamSQLEnum,
ProtocolKindSQLEnum,
)
Expand All @@ -29,7 +28,6 @@
"action_table",
"run_csv_rtp_table",
"data_files_table",
"run_csv_rtp_table",
"PrimitiveParamSQLEnum",
"ProtocolKindSQLEnum",
]
7 changes: 5 additions & 2 deletions robot-server/tests/runs/test_run_store.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
"""Tests for robot_server.runs.run_store."""
from datetime import datetime, timezone
from pathlib import Path
from typing import List, Optional, Type

import pytest
Expand Down Expand Up @@ -206,14 +207,16 @@ def invalid_state_summary() -> StateSummary:


@pytest.fixture
def data_files_store(sql_engine: Engine) -> DataFilesStore:
def data_files_store(sql_engine: Engine, tmp_path: Path) -> DataFilesStore:
"""Return a `DataFilesStore` linked to the same database as the subject under test.
`DataFilesStore` is tested elsewhere.
We only need it here to prepare the database for the analysis store tests.
The CSV parameters table always needs a data file to link to.
"""
return DataFilesStore(sql_engine=sql_engine)
data_files_dir = tmp_path / "data_files"
data_files_dir.mkdir()
return DataFilesStore(sql_engine=sql_engine, data_files_directory=data_files_dir)


async def test_update_run_state(
Expand Down

0 comments on commit f233d0e

Please sign in to comment.