Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python): configure setuptools to use legacy editable installs in release branch #11347

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

sanni-t
Copy link
Member

@sanni-t sanni-t commented Aug 15, 2022

Overview

Cherry-picks @mcous 's build fix commit for the release branch

Changelog

Same as #11341

Review requests

Make sure CI clears on this PR

Risk assessment

Low for this branch. Duplicating PR that's already merged to edge. Might cause conflicts later when merging release to edge.

@sanni-t sanni-t requested a review from a team as a code owner August 15, 2022 18:46
@sanni-t sanni-t requested a review from a team August 15, 2022 18:46
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #11347 (87b89ab) into release_6.1.0 (1a98822) will decrease coverage by 0.60%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release_6.1.0   #11347      +/-   ##
=================================================
- Coverage          71.87%   71.27%   -0.61%     
=================================================
  Files               1048     1253     +205     
  Lines              17151    24355    +7204     
  Branches            3710     3820     +110     
=================================================
+ Hits               12328    17359    +5031     
- Misses              3857     6022    +2165     
- Partials             966      974       +8     
Flag Coverage Δ
app 73.72% <ø> (ø)
g-code-testing 97.13% <ø> (?)
hardware 59.10% <ø> (?)
notify-server 89.17% <ø> (?)
shared-data 86.08% <ø> (-8.21%) ⬇️
update-server 73.11% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/opentrons_hardware/firmware_update/downloader.py 100.00% <0.00%> (ø)
hardware/opentrons_hardware/scripts/can_args.py 33.33% <0.00%> (ø)
.../thermocycler/open_lid_g_code_functionality_def.py 100.00% <0.00%> (ø)
...hardware/hardware_control/motion_planning/types.py 90.99% <0.00%> (ø)
...dware/hardware_control/motion_planning/__init__.py 100.00% <0.00%> (ø)
shared-data/js/helpers/schemaV6Adapter.ts 7.14% <0.00%> (ø)
hardware/opentrons_hardware/sensors/hdc2080.py 100.00% <0.00%> (ø)
.../opentrons_hardware/firmware_bindings/constants.py 100.00% <0.00%> (ø)
...cycler/edit_pid_params_g_code_functionality_def.py 100.00% <0.00%> (ø)
hardware/opentrons_hardware/scripts/sensors.py 0.00% <0.00%> (ø)
... and 196 more

@mcous mcous merged commit b3d533c into release_6.1.0 Aug 15, 2022
@mcous mcous deleted the ci_fix_mypy_in_release_6.1.0 branch August 15, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants