-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(shared-data,app): migrate to deck definition v4 #13931
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13931 +/- ##
==========================================
- Coverage 70.79% 70.64% -0.15%
==========================================
Files 2505 2506 +1
Lines 70620 71217 +597
Branches 8663 8898 +235
==========================================
+ Hits 49997 50313 +316
- Misses 18501 18750 +249
- Partials 2122 2154 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
|
changes default OT-2/Flex deck definitions to v4 in shared-data, app, components, and protocol designer closes RAUT-781
b-cooper
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛡️
ncdiehl11
pushed a commit
that referenced
this pull request
Nov 14, 2023
changes default OT-2/Flex deck definitions to v4 in shared-data, app, components, and protocol designer closes RAUT-781 --------- Co-authored-by: Brian Cooper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
changes default OT-2/Flex deck definitions to v4 in shared-data, app, components, and protocol designer
TODO:
Test Plan
Changelog
Review requests
review app and PD for regressions and errors
Risk assessment
medium