Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(shared-data,app): migrate to deck definition v4 #13931

Merged
merged 30 commits into from
Nov 10, 2023

Conversation

brenthagen
Copy link
Contributor

@brenthagen brenthagen commented Nov 6, 2023

Overview

changes default OT-2/Flex deck definitions to v4 in shared-data, app, components, and protocol designer

TODO:

  • update/fix unit tests
  • enumerate and filter by correct cutout fixture ids in BaseDeck
  • resolve PD DeckSetup whitescreen
  • fix storybook errors

Test Plan

  • update unit tests
  • audit protocol/device pages throughout app and PD for regressions and errors

Changelog

  • Migrates app, components, and protocol designer to deck definition v4

Review requests

review app and PD for regressions and errors

Risk assessment

medium

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #13931 (827da77) into edge (7258da8) will decrease coverage by 0.15%.
Report is 9 commits behind head on edge.
The diff coverage is 41.80%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #13931      +/-   ##
==========================================
- Coverage   70.79%   70.64%   -0.15%     
==========================================
  Files        2505     2506       +1     
  Lines       70620    71217     +597     
  Branches     8663     8898     +235     
==========================================
+ Hits        49997    50313     +316     
- Misses      18501    18750     +249     
- Partials     2122     2154      +32     
Flag Coverage Δ
app 67.51% <51.51%> (-0.54%) ⬇️
components 62.90% <25.28%> (-0.25%) ⬇️
labware-library 51.50% <ø> (ø)
protocol-designer 45.87% <19.35%> (+0.06%) ⬆️
react-api-client 65.96% <ø> (ø)
shared-data 73.29% <82.25%> (+0.15%) ⬆️
step-generation 86.60% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/molecules/DeckThumbnail/index.tsx 85.18% <ø> (ø)
app/src/organisms/CalibrationPanels/DeckSetup.tsx 56.52% <ø> (ø)
...DeviceDetailsDeckConfiguration/AddFixtureModal.tsx 81.81% <100.00%> (ø)
...organisms/Devices/ProtocolRun/ProtocolRunSetup.tsx 75.94% <ø> (ø)
...olRun/SetupModuleAndDeck/LocationConflictModal.tsx 85.00% <ø> (ø)
.../Devices/ProtocolRun/utils/getLabwareRenderInfo.ts 71.42% <100.00%> (-5.24%) ⬇️
...InterventionModal/utils/getRunLabwareRenderInfo.ts 83.33% <100.00%> (ø)
.../InterventionModal/utils/getRunModuleRenderInfo.ts 100.00% <100.00%> (ø)
...src/organisms/ModuleWizardFlows/SelectLocation.tsx 14.28% <ø> (ø)
app/src/organisms/ProtocolDetails/index.tsx 42.85% <ø> (ø)
... and 54 more

... and 22 files with indirect coverage changes

@brenthagen brenthagen changed the title Shared data v4 deck def migration refactor(shared-data,app): migrate to deck definition v4 Nov 8, 2023
@brenthagen brenthagen marked this pull request as ready for review November 8, 2023 16:33
@brenthagen brenthagen requested a review from a team as a code owner November 8, 2023 16:33
@brenthagen brenthagen requested a review from a team November 8, 2023 16:33
@brenthagen brenthagen requested a review from a team as a code owner November 8, 2023 16:33
@brenthagen brenthagen requested review from b-cooper and removed request for a team and b-cooper November 8, 2023 16:33
@brenthagen brenthagen requested a review from a team as a code owner November 9, 2023 19:59
@brenthagen brenthagen removed the request for review from a team November 9, 2023 20:09
Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛡️

@brenthagen brenthagen merged commit 91c7aaf into edge Nov 10, 2023
@brenthagen brenthagen deleted the shared-data_v4-deck-def-migration branch November 10, 2023 01:44
ncdiehl11 pushed a commit that referenced this pull request Nov 14, 2023
changes default OT-2/Flex deck definitions to v4 in shared-data, app, components, and protocol
designer

closes RAUT-781

---------

Co-authored-by: Brian Cooper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants