refactor(components): update deck map and deck configurator styling #13946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update deckmap and deck configurator styling close RAUT-773
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13946 +/- ##
==========================================
- Coverage 70.56% 70.56% -0.01%
==========================================
Files 2467 2467
Lines 68051 68057 +6
Branches 8687 8688 +1
==========================================
+ Hits 48023 48027 +4
- Misses 17901 17903 +2
Partials 2127 2127
Flags with carried forward coverage won't be shown. Click here to find out more.
|
koji
changed the title
ncdiehl11
pushed a commit
that referenced
this pull request
Nov 14, 2023
* refactor(app): update deck configurator styling (#13946)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
update deck map and deck configurator styling
Deck map part will be followed by another pr.
design
https://www.figma.com/file/1ot18My22DALIcjdLl5LJh/Helix-Design-System?node-id=358%3A76193&mode=dev
I'm asking about the border-radius size to Mel since the size in the design is 3.46px but we don't have it as a radius size const.There are some same styles in waste chute, trash bin, and staging area. I think we can create a common style and share it with them, but we can do it after 7.1.0 and we can have a rule for this kind of case.
close RAUT-773 partially
Test Plan
Go to Device Details page in Desktop app
Changelog
Review requests
Risk assessment
low