feat(protocol-designer): wireup wasteChute commands #13953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we select the waste chute as our drop tip location, we need to generate different commands from dropping tips in other locations. For the waste chute, we generate moveToAddressableArea followed by dropTipInPlace commands.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13953 +/- ##
==========================================
- Coverage 70.62% 65.34% -5.28%
==========================================
Files 2481 1317 -1164
Lines 69984 30091 -39893
Branches 8525 5519 -3006
==========================================
- Hits 49426 19663 -29763
+ Misses 18465 8861 -9604
+ Partials 2093 1567 -526
Flags with carried forward coverage won't be shown. Click here to find out more.
|
adds command text with requisite params for dropTipInPlace, dispenseInPlace, blowOutInPlace, and moveToAddressableArea
jerader
reviewed
Nov 9, 2023
protocol-designer/src/timelineMiddleware/generateRobotStateTimeline.ts
Outdated
Show resolved
Hide resolved
protocol-designer/src/timelineMiddleware/generateRobotStateTimeline.ts
Outdated
Show resolved
Hide resolved
Within the file browser that launches when importing protocols or labware into the Opentrons App, support multi file select. Closes RAUT-218
ODD optimizations do not prevent step meter tearing on the physical ODD when step progress regresses. Playing no animation solves the problem until we optimize ODD animations.
* feat(app): add release notes button on app & robot update modals * fix(app): fix closing app update modal during robot downgrade When downgrading a robot, users are first prompted if they'd like to update their app. When clicking close, the downgrade should proceed instead of crashing the app.
The tests that were supposed to ajv the pipette definitions weren't set up properly, and the tests that were supposed to test that the tests were set up properly weren't set up properly, so we weren't testing the schemas so the schemas were wrong. Fix the schema-test setup, the test-setup-schema-test setup, and the schema.
changes default OT-2/Flex deck definitions to v4 in shared-data, app, components, and protocol designer closes RAUT-781 --------- Co-authored-by: Brian Cooper <[email protected]>
closes RAUT-851 Generate different commands from dropping tips in other locations if we select the waste chute as our drop tip location. For the waste chute, we generate moveToAddressableArea followed by dropTipInPlace commands.
|
moved to here after rebase disaster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RAUT-767
Overview
This PR updates the pipetting compound commands to check the dropTipLocation. If the location is included in additionalEquipment, wasteChuteCommandsUtil is called with the correct arguments needed. This is plugged into returnTip and generateRobotStateTimeline.
We also update the robot tip state when the commands get emitted by updating forDropTipLocation.
Test Plan
Changelog
Review requests
@jerader per collaboration
Risk assessment