feat(app): add inPlace and moveToAddressableArea command text #13958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we select the waste chute as our drop tip location, we need to generate different commands from dropping tips in other locations. For the waste chute, we generate moveToAddressableArea followed by dropTipInPlace commands.
adds command text with requisite params for dropTipInPlace, dispenseInPlace, blowOutInPlace, and moveToAddressableArea
adds command text with requisite params for dropTipInPlace, dispenseInPlace, blowOutInPlace, and moveToAddressableArea
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13958 +/- ##
==========================================
- Coverage 70.65% 70.48% -0.17%
==========================================
Files 2482 2510 +28
Lines 71432 71788 +356
Branches 9320 9122 -198
==========================================
+ Hits 50468 50603 +135
- Misses 18815 18969 +154
- Partials 2149 2216 +67
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ncdiehl11
changed the title
jerader
reviewed
Nov 9, 2023
jerader
approved these changes
Nov 9, 2023
ncdiehl11
added a commit
that referenced
this pull request
Nov 14, 2023
closes RAUT-851 Generate different commands from dropping tips in other locations if we select the waste chute as our drop tip location. For the waste chute, we generate moveToAddressableArea followed by dropTipInPlace commands.
ahiuchingau
pushed a commit
that referenced
this pull request
Nov 15, 2023
closes RAUT-851 Generate different commands from dropping tips in other locations if we select the waste chute as our drop tip location. For the waste chute, we generate moveToAddressableArea followed by dropTipInPlace commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RAUT-851
Overview
Adds new command text for in place commands and moveToAddressableArea
Test Plan
Changelog
Risk assessment
low