feat(components): render 4th column slot label for staging area slots #13969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt in deck config Creates a 4th column in SlotLabels component to be rendered if used for coordinates for slot positions AND at least one staging area fixture exists in deck config. Note that SlotLabels do not render 4th column when rendered as coordinates for fixture positions
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13969 +/- ##
==========================================
- Coverage 70.67% 70.61% -0.07%
==========================================
Files 2505 2506 +1
Lines 70883 70923 +40
Branches 8756 8798 +42
==========================================
- Hits 50097 50080 -17
- Misses 18644 18694 +50
- Partials 2142 2149 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jerader
approved these changes
Nov 13, 2023
jerader
reviewed
Nov 14, 2023
jerader
approved these changes
Nov 14, 2023
brenthagen
reviewed
Nov 15, 2023
brenthagen
reviewed
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RAUT-782
Overview
Creates a 4th column in SlotLabels component to be rendered if used for coordinates for slot positions AND at least one staging area fixture exists in deck config. Note that SlotLabels do not render 4th column when rendered as coordinates for fixture positions.
Test Plan
Changelog
Review requests
@brenthagen
Risk assessment
low