Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): remove app fixture stubs #13980

Merged
merged 22 commits into from
Nov 15, 2023
Merged

Conversation

brenthagen
Copy link
Contributor

@brenthagen brenthagen commented Nov 14, 2023

Overview

removes the stubbed "load fixture" commands and stubbed fixtures. adds getSimplestDeckConfigForProtocolCommands utility to generate a deck configuration from a protocol analysis. fixes/removes various deprecated or temporary types.

Test Plan

  • updated unit tests
  • manually verified desktop/ODD app rendering and some fixture conflicts

Changelog

  • Removes desktop/ODD app fixture stubs

Review requests

smoke test ODD/desktop app

Risk assessment

medium

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #13980 (6294fa9) into edge (44c3f56) will decrease coverage by 0.04%.
Report is 1 commits behind head on edge.
The diff coverage is 58.19%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #13980      +/-   ##
==========================================
- Coverage   70.70%   70.67%   -0.04%     
==========================================
  Files        2506     2505       -1     
  Lines       70798    70832      +34     
  Branches     8714     8738      +24     
==========================================
- Hits        50060    50058       -2     
- Misses      18610    18639      +29     
- Partials     2128     2135       +7     
Flag Coverage Δ
app 67.76% <61.49%> (-0.12%) ⬇️
components 62.84% <58.33%> (-0.07%) ⬇️
labware-library 51.50% <ø> (ø)
protocol-designer 45.67% <45.83%> (+0.02%) ⬆️
react-api-client 65.87% <ø> (-0.09%) ⬇️
shared-data 73.15% <42.85%> (-0.14%) ⬇️
step-generation 86.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/molecules/DeckThumbnail/index.tsx 88.88% <100.00%> (ø)
...organisms/Devices/ProtocolRun/ProtocolRunSetup.tsx 79.01% <100.00%> (+3.06%) ⬆️
...vices/ProtocolRun/SetupLabware/SetupLabwareMap.tsx 88.88% <100.00%> (ø)
...vices/ProtocolRun/SetupLiquids/SetupLiquidsMap.tsx 59.25% <100.00%> (ø)
...rotocolRun/SetupModuleAndDeck/SetupModulesList.tsx 82.35% <100.00%> (+0.81%) ⬆️
...ProtocolRun/SetupModuleAndDeck/SetupModulesMap.tsx 87.50% <100.00%> (+0.83%) ⬆️
...isms/ProtocolDetails/RobotConfigurationDetails.tsx 78.57% <100.00%> (-2.20%) ⬇️
...nisms/ProtocolSetupLabware/LabwareMapViewModal.tsx 72.72% <100.00%> (ø)
...SetupModulesAndDeck/ModulesAndDeckMapViewModal.tsx 75.00% <100.00%> (ø)
...rc/organisms/ProtocolSetupModulesAndDeck/index.tsx 68.35% <100.00%> (+0.40%) ⬆️
... and 26 more

... and 1 file with indirect coverage changes

@brenthagen brenthagen marked this pull request as ready for review November 14, 2023 23:27
@brenthagen brenthagen requested review from a team as code owners November 14, 2023 23:27
@brenthagen brenthagen requested a review from a team November 14, 2023 23:27
@brenthagen brenthagen requested a review from a team as a code owner November 14, 2023 23:27
@brenthagen brenthagen removed the request for review from a team November 14, 2023 23:27
@brenthagen brenthagen requested review from shlokamin and removed request for a team and shlokamin November 14, 2023 23:27
Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚤

@brenthagen brenthagen merged commit e5eb78b into edge Nov 15, 2023
@brenthagen brenthagen deleted the app_remove-load-fixture-stubs branch November 15, 2023 03:54
ahiuchingau pushed a commit that referenced this pull request Nov 15, 2023
remove fixture stubs throughout desktop/ODD app, update types, and add deck conflict compatibility
checks

closes RAUT-859

---------

Co-authored-by: Brian Cooper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants