-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: internal-release->edge for 1.0.0 #14003
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… log (#13961) * feat(shared-data, app): add configureNozzleLayout command type and run log support
The 96 channel pipette is not capable of continuously checking for the presence of a tip (or indeed a calibration probe). It needs to run a special routing, exposed through ot3api.get_tip_presence_status() or ot3api.verify_tip_presence(), to check for a tip. This happens automatically in most of the places we use tips - aka inside other protocol engine commands - but it does not happen automatically and all the time. This is usually fine, but when we're doing calibration we do it through a protocol engine maintenance run where the way we interact with the robot is dispatching PE commands - and we don't ever dispatch a PE command that implicitly causes a tip check. That means that the 96 can't be relied on to get the presence of a tip. The long term fix for this is to add a checkTipPresence command to the engine, at least as a maintenance command; in the short term, we can disable the presence check for 96 channel pipettes to unblock testing. Closes RQA-1892
* chore: update update-from-usb fake release notes * Flex
…13993) Updates from hardware for 96 channel ul/mm --------- Co-authored-by: Seth Foster <[email protected]>
Laura-Danielle
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚡
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #14003 +/- ##
==========================================
- Coverage 70.73% 70.64% -0.10%
==========================================
Files 2506 2507 +1
Lines 70747 72916 +2169
Branches 8707 9383 +676
==========================================
+ Hits 50040 51508 +1468
- Misses 18585 19159 +574
- Partials 2122 2249 +127
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mergeback PR for the internal release 1.0.0 release process.