Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: internal-release->edge for 1.0.0 #14003

Merged
merged 6 commits into from
Nov 16, 2023
Merged

chore: internal-release->edge for 1.0.0 #14003

merged 6 commits into from
Nov 16, 2023

Conversation

sfoster1
Copy link
Member

This is a mergeback PR for the internal release 1.0.0 release process.

sfoster1 and others added 6 commits November 13, 2023 16:51
Since ac0304a we were not properly
setting the folder-part of the app update flow in internal-releases
which meant the app couldn't update.

Closes RQA-1882
… log (#13961)

* feat(shared-data, app): add configureNozzleLayout command type and run log support
The 96 channel pipette is not capable of continuously checking for the
presence of a tip (or indeed a calibration probe). It needs to run a
special routing, exposed through ot3api.get_tip_presence_status() or
ot3api.verify_tip_presence(), to check for a tip. This happens
automatically in most of the places we use tips - aka inside other
protocol engine commands - but it does not happen automatically and all
the time.

This is usually fine, but when we're doing calibration we do it through
a protocol engine maintenance run where the way we interact with the
robot is dispatching PE commands - and we don't ever dispatch a PE
command that implicitly causes a tip check. That means that the 96 can't
be relied on to get the presence of a tip.

The long term fix for this is to add a checkTipPresence command to the
engine, at least as a maintenance command; in the short term, we can
disable the presence check for 96 channel pipettes to unblock testing.

Closes RQA-1892
* chore: update update-from-usb fake release notes

* Flex
…13993)

Updates from hardware for 96 channel ul/mm

---------

Co-authored-by: Seth Foster <[email protected]>
@sfoster1 sfoster1 requested review from a team as code owners November 16, 2023 18:03
@sfoster1 sfoster1 requested review from jerader and removed request for a team November 16, 2023 18:03
Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #14003 (c80798d) into edge (91c7aaf) will decrease coverage by 0.10%.
Report is 27 commits behind head on edge.
The diff coverage is 36.84%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14003      +/-   ##
==========================================
- Coverage   70.73%   70.64%   -0.10%     
==========================================
  Files        2506     2507       +1     
  Lines       70747    72916    +2169     
  Branches     8707     9383     +676     
==========================================
+ Hits        50040    51508    +1468     
- Misses      18585    19159     +574     
- Partials     2122     2249     +127     
Flag Coverage Δ
app 68.21% <36.84%> (+0.36%) ⬆️
components 62.90% <ø> (ø)
g-code-testing 96.44% <ø> (ø)
hardware 56.91% <ø> (+0.05%) ⬆️
hardware-testing ∅ <ø> (∅)
labware-library 51.50% <ø> (ø)
notify-server 89.13% <ø> (ø)
protocol-designer 45.94% <ø> (+0.18%) ⬆️
react-api-client 65.96% <ø> (ø)
shared-data 73.06% <ø> (-0.23%) ⬇️
step-generation 86.60% <ø> (ø)
system-server 96.02% <ø> (ø)
update-server 63.51% <ø> (ø)
usb-bridge 76.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app-shell-odd/src/system-update/index.ts 0.00% <ø> (ø)
...src/organisms/CommandText/PipettingCommandText.tsx 87.93% <100.00%> (+5.32%) ⬆️
...p/src/organisms/PipetteWizardFlows/AttachProbe.tsx 75.51% <0.00%> (ø)
...src/organisms/LabwarePositionCheck/AttachProbe.tsx 4.65% <0.00%> (-0.12%) ⬇️
app/src/organisms/CommandText/index.tsx 76.00% <50.00%> (-7.68%) ⬇️
...pp/src/organisms/CommandText/utils/getWellRange.ts 11.11% <11.11%> (ø)

... and 69 files with indirect coverage changes

@sfoster1 sfoster1 merged commit dc93386 into edge Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants