Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): MoveToAddressableArea noop not raise #14015

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

sfoster1
Copy link
Member

This lets us test the parts of the frontend that require the command.

This lets us test the parts of the frontend that require the command.
@sfoster1 sfoster1 requested review from a team November 16, 2023 22:20
@sfoster1 sfoster1 requested a review from a team as a code owner November 16, 2023 22:20
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #14015 (11cf7f7) into edge (09d48ce) will increase coverage by 0.00%.
Report is 3 commits behind head on edge.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #14015   +/-   ##
=======================================
  Coverage   70.68%   70.68%           
=======================================
  Files        1628     1628           
  Lines       54245    54246    +1     
  Branches     3858     3858           
=======================================
+ Hits        38342    38345    +3     
+ Misses      15236    15235    -1     
+ Partials      667      666    -1     
Flag Coverage Δ
app 38.62% <ø> (+0.06%) ⬆️
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)
protocol-designer 45.67% <ø> (ø)
shared-data 73.58% <100.00%> (+<0.01%) ⬆️
step-generation 86.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
..._shared_data/protocol/models/protocol_schema_v8.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@sfoster1 sfoster1 merged commit 388d106 into edge Nov 16, 2023
@sfoster1 sfoster1 deleted the noop-move-to-area branch November 16, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants