chore: verbose pypi deploys to catch errors #14441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.0 #14441 +/- ##
====================================================
Coverage 68.14% 68.14%
====================================================
Files 2518 2518
Lines 72009 72009
Branches 9232 9232
====================================================
+ Hits 49067 49072 +5
+ Misses 20743 20738 -5
Partials 2199 2199
Flags with carried forward coverage won't be shown. Click here to find out more. |
SyntaxColoring
approved these changes
Feb 7, 2024
| define python_upload_package | ||
| $(python) -m twine upload --repository-url $(2) $(1) $(3) | ||
| $(python) -m twine upload $(and $(CI),--verbose) --repository-url $(2) $(1) $(3) $(4) |
There was a problem hiding this comment.
I'd be down for --verbose to be unconditional, if that simplifies things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our pypi deploys seem to have succeeded in that the build is on pypi (https://pypi.org/project/opentrons/7.1.1a0/#files) but failed in that the action said there was an error and you should run with --verbose, so let's do that.