Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): add prop so run setup pipette flows are strung together #14460

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Feb 8, 2024

Fix RQA-2305, RQA-2292, RQA-2284

Overview

This PR fixes a few bugs (or missing implementations) in pipette flows on the ODD and app. It ensures pipette detach -> attach flows are properly strung together for ODD instrument setup and adds a "Robot is Moving" loading screen after attaching a mounting plate during 96-channel attach

Test Plan

On ODD,

  1. From run setup with the wrong instruments attached, the ODD should now initiate a "Replace pipette" flow:
    IMG_6670

  2. From run setup with a single channel on the left mount for a protocol that requires an ODD, the replace pipette flow should show the correct pipette name in the detach step and lower the correct mount:
    IMG_6672
    IMG_6673

  3. When attaching a 96-channel pipette, there should be a loading screen while the gantry moves after attaching a mounting plate

Changelog

Review requests

Look over code and screenshots

Risk assessment

Low

@smb2268 smb2268 self-assigned this Feb 8, 2024
@smb2268 smb2268 requested a review from a team as a code owner February 8, 2024 21:28
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8dc44b0) 67.70% compared to head (c55178a) 67.77%.
Report is 1 commits behind head on chore_release-7.2.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14460      +/-   ##
=======================================================
+ Coverage                67.70%   67.77%   +0.07%     
=======================================================
  Files                     1628     2518     +890     
  Lines                    54904    71969   +17065     
  Branches                  4147     9245    +5098     
=======================================================
+ Hits                     37172    48777   +11605     
- Misses                   17042    20989    +3947     
- Partials                   690     2203    +1513     
Flag Coverage Δ
app 64.58% <0.00%> (+30.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nstrumentMountItem/ProtocolInstrumentMountItem.tsx 95.34% <ø> (ø)
...p/src/organisms/ProtocolSetupInstruments/index.tsx 41.17% <ø> (ø)
...src/organisms/PipetteWizardFlows/MountingPlate.tsx 75.00% <0.00%> (ø)

... and 887 files with indirect coverage changes

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM!

@smb2268 smb2268 merged commit ce940e8 into chore_release-7.2.0 Feb 9, 2024
21 of 22 checks passed
@smb2268 smb2268 deleted the app_odd-pipette-flows branch February 9, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants