Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared-data): allow thermocycler to be loaded on slot B1 only #14527

Conversation

TamarZanzouri
Copy link
Contributor

Overview

closes https://opentrons.atlassian.net/browse/RSS-472.
shared-data deck config mistakenly allowed loading a thermocycler module in slot A1 on the flex.
on the OT-2 we allow only loading on slot 7.

Test Plan

uploading the following protocol on the flex should fail analysis.

requirements = {
	"robotType": "Flex",
	"apiLevel": "2.16",
}

def run(protocol):
	thermocycler  = protocol.load_module('thermocycler module gen2', "A1")

Changelog

removed thermocyclerModuleType from slot A1 in the deck definition.

Review requests

Should I add tests?

Risk assessment

low.

@TamarZanzouri TamarZanzouri requested a review from a team February 20, 2024 18:32
@TamarZanzouri TamarZanzouri requested a review from a team as a code owner February 20, 2024 18:32
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (149aa7d) 67.76% compared to head (02a4caf) 67.78%.
Report is 1 commits behind head on chore_release-7.2.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14527      +/-   ##
=======================================================
+ Coverage                67.76%   67.78%   +0.01%     
=======================================================
  Files                     2517     2517              
  Lines                    72057    72124      +67     
  Branches                  9276     9327      +51     
=======================================================
+ Hits                     48831    48889      +58     
- Misses                   21008    21016       +8     
- Partials                  2218     2219       +1     
Flag Coverage Δ
app 64.71% <ø> (+0.07%) ⬆️
protocol-designer 37.93% <ø> (ø)
shared-data 75.26% <ø> (ø)
step-generation 86.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it when the fix can "B" "1" line

ha ha

ha

@TamarZanzouri TamarZanzouri merged commit 2e23204 into chore_release-7.2.0 Feb 20, 2024
56 checks passed
@TamarZanzouri TamarZanzouri deleted the RSS-472-no-error-when-loading-thermocycler-in-slot-a-1-on-flex branch February 20, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants