Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app-shell, app-shell-odd): reduce port block analytics reporting frequency #14550

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Feb 26, 2024

Closes RQA-2385

Overview

Instead of reporting every port block event that can happen in an app session (which can be excessive), let's just report one event per session.

Test Plan

  • Verified on my Mixpanel acct that port block events aren't excessive.

Review requests

  • Just verify the logic is sound. I think reporting this event once per app session is fine. At the end of the day, we just want to use this number to gauge the # of users who experience port blocking issues. We can filter by robot, ID, etc. in Mixpanel to fine tune the results. Let's just cut down on the overall chatter here.

Risk assessment

low

…frequency

Instead of reporting every port block event, let's just report one event per session of the desktop
app/odd.
@mjhuff mjhuff requested a review from a team February 26, 2024 19:13
@mjhuff mjhuff requested review from a team as code owners February 26, 2024 19:13
@mjhuff mjhuff requested review from jerader and removed request for a team February 26, 2024 19:13
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 67.73%. Comparing base (10c0e77) to head (ba5ba22).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14550      +/-   ##
=======================================================
- Coverage                67.74%   67.73%   -0.02%     
=======================================================
  Files                     2517     2517              
  Lines                    72154    72166      +12     
  Branches                  9291     9293       +2     
=======================================================
  Hits                     48882    48882              
- Misses                   21052    21064      +12     
  Partials                  2220     2220              
Flag Coverage Δ
app 64.53% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app-shell-odd/src/notify.ts 0.00% <0.00%> (ø)
app-shell/src/notify.ts 0.00% <0.00%> (ø)

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@mjhuff mjhuff merged commit bfd3145 into chore_release-7.2.0 Feb 26, 2024
27 of 28 checks passed
@mjhuff mjhuff deleted the app_reduce-mqtt-reporting branch February 26, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants