Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): Add release notes for RSS-468 #14551

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

SyntaxColoring
Copy link
Contributor

Overview

Add a release note for RSS-468 / PR #14512.

Review requests

  • Can this be made less wordy?
  • Do we say "OT-2" or "The OT-2" or "OT-2 robots" these days?
  • Is the Capitalization of "Labware Position Check" and "Tip Length Calibration" Appropriate?

Risk assessment

No risk.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.60%. Comparing base (9607d67) to head (5e1244d).
Report is 7 commits behind head on chore_release-7.2.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14551      +/-   ##
=======================================================
- Coverage                67.76%   67.60%   -0.16%     
=======================================================
  Files                     2521     2521              
  Lines                    72188    72405     +217     
  Branches                  9291     9344      +53     
=======================================================
+ Hits                     48915    48949      +34     
- Misses                   21052    21234     +182     
- Partials                  2221     2222       +1     
Flag Coverage Δ
app 64.07% <ø> (-0.56%) ⬇️
g-code-testing 92.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be made less wordy?

pushed a commit with copy edits.

Do we say "OT-2" or "The OT-2" or "OT-2 robots" these days?

went with "The OT-2" for parallelism with

- The OT-2 now accurately calculates the position of the Thermocycler. If you previously compensated for the incorrect position with labware offsets, re-run Labware Position Check to avoid pipette crashes.

no hard and fast rule though.

Is the Capitalization of "Labware Position Check" and "Tip Length Calibration" Appropriate?

title case for Labware Position Check. lowercase for tip length calibration. at least per the Glossary

remaining question
that line cited above ☝️ is in the app-shell notes. i think that was because of the focus on "hey, re-run LPC, an app feature." this is a pretty similar fix / required user action. so it should probably be moved or copied to the other notes file as well.

Copy link
Contributor

@jwwojak jwwojak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reasonable and clear. LGTM.
:shipit:

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner February 28, 2024 14:29
@SyntaxColoring SyntaxColoring requested review from TamarZanzouri and removed request for a team February 28, 2024 14:29
@SyntaxColoring
Copy link
Contributor Author

remaining question that line cited above ☝️ is in the app-shell notes. i think that was because of the focus on "hey, re-run LPC, an app feature." this is a pretty similar fix / required user action. so it should probably be moved or copied to the other notes file as well.

I probably wouldn't have added the Thermocycler thing to the app-shell notes. Taking that for granted, though, it sounds like both notes should be in both places, so I've copied them.

Another vote for merging the release note files, I guess.

Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👯

Further votes on the future of release notes can go in RTC-135.

@SyntaxColoring SyntaxColoring merged commit 38f911b into chore_release-7.2.0 Feb 28, 2024
38 checks passed
@SyntaxColoring SyntaxColoring deleted the tlc_release_notes branch February 28, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants