-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): Add release notes for RSS-468 #14551
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.0 #14551 +/- ##
=======================================================
- Coverage 67.76% 67.60% -0.16%
=======================================================
Files 2521 2521
Lines 72188 72405 +217
Branches 9291 9344 +53
=======================================================
+ Hits 48915 48949 +34
- Misses 21052 21234 +182
- Partials 2221 2222 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be made less wordy?
pushed a commit with copy edits.
Do we say "OT-2" or "The OT-2" or "OT-2 robots" these days?
went with "The OT-2" for parallelism with
- The OT-2 now accurately calculates the position of the Thermocycler. If you previously compensated for the incorrect position with labware offsets, re-run Labware Position Check to avoid pipette crashes. |
no hard and fast rule though.
Is the Capitalization of "Labware Position Check" and "Tip Length Calibration" Appropriate?
title case for Labware Position Check. lowercase for tip length calibration. at least per the Glossary
remaining question
that line cited above ☝️ is in the app-shell
notes. i think that was because of the focus on "hey, re-run LPC, an app feature." this is a pretty similar fix / required user action. so it should probably be moved or copied to the other notes file as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is reasonable and clear. LGTM.
I probably wouldn't have added the Thermocycler thing to the Another vote for merging the release note files, I guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👯
Further votes on the future of release notes can go in RTC-135.
Overview
Add a release note for RSS-468 / PR #14512.
Review requests
Risk assessment
No risk.