feat(app): mark protocol anlayses as stale if they lack RTP #14763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently display a stale anlaysis banner for protocols that are determined to require reanalysis. The current check is for the lack of a `liquids` key on the analysis output. Now, we also want to check for the lack of a `runTimeParmeters` key, as all analyses should contain this key, even if its value is an empty list.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14763 +/- ##
==========================================
+ Coverage 67.17% 67.20% +0.02%
==========================================
Files 2495 2495
Lines 71483 71404 -79
Branches 9020 8991 -29
==========================================
- Hits 48020 47985 -35
+ Misses 21341 21304 -37
+ Partials 2122 2115 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jerader
reviewed
Apr 1, 2024
| @@ -3936,5 +3936,6 @@ | |||
| "description": "", | |||
| "displayColor": "#b925ff" | |||
| } | |||
| ] | |||
| ], | |||
| "runTimeParameters": [] | |||
There was a problem hiding this comment.
🚀 yay so cool seeing this key in fixtures!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-247
Overview
We currently display a stale anlaysis banner for protocols that are determined to require reanalysis. The current check is for the lack of a
liquidskey on the analysis output. Now, we also want to check for the lack of arunTimeParmeterskey, as all analyses should contain this key, even if its value is an empty list.Test Plan
runTimeParameters. To do this, you can open the protocol's overflow menu, select 'Show in folder', open the latest analysis, and remove therunTimeParameterskey and value if it existsChangelog
getAnalysisStatusutil to check for presence of RTP keyrunTimeParametersfield to test fixtureReview requests
authorship devs
Risk assessment
low