fix(app): fix excessive /runs network requests #14783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes useNotifyService to check hostname instead of the host object, preventing a pass by reference issue causing excessive requests sent to /runs.
mjhuff
requested review from
TamarZanzouri
and removed request for
a team and
TamarZanzouri
DerekMaggio
reviewed
Apr 3, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
Closes EXEC-255 UseNotifyService utilizes hostname instead of the host object, preventing a pass by reference issue causing excessive requests sent to /runs that often occurs on the RobotDetails page. Let's also ensure that if a robot loses connection while a component has passed a callback to appShellListener, we ensure we remove the correct callback from the store.
Carlos-fernandez
pushed a commit
that referenced
this pull request
Jun 3, 2024
Closes EXEC-255 UseNotifyService utilizes hostname instead of the host object, preventing a pass by reference issue causing excessive requests sent to /runs that often occurs on the RobotDetails page. Let's also ensure that if a robot loses connection while a component has passed a callback to appShellListener, we ensure we remove the correct callback from the store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EXEC-255
Overview
Fixes useNotifyService to utilize hostname instead of the
hostobject, preventing a pass by reference issue causing excessive requests sent to/runsthat often occurs on the RobotDetails page. This fix is sufficient, since this is all we need fromhostanyway. Let's also ensure that if a robot loses connection while a component has passed a callback toappShellListener, we ensure we remove the correct callback from the store.Current Behavior
Screen.Recording.2024-04-02.at.4.49.28.PM.mov
Fixed Bevahior
Screen.Recording.2024-04-02.at.4.48.41.PM.mov
Test Plan
Changelog
Risk assessment
low