fix(app,components): fix module controls no module connected case #14784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connect modules to see controls doesn't align with the design. This PR fixes. The component is the same as NoParameters component so I rename and add a new prop to use only one component. close AUTH-264
ncdiehl11
approved these changes
Apr 3, 2024
Actually, I've been thinking about that. Also, I think solution would depend on UI components' goal since @opentrons/components is published. |
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
…4784) * fix(app,components): fix module controls no module connected case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
While I was working on Protocol Run page for RTP, I noticed that
Connect modules to see controlsis different from No Parameters even they are in the same page.Mel updated the design.
https://www.figma.com/file/l7BAJAGICr10ELsSqQD0Sr/Design-System%3A-Desktop?node-id=14096%3A7516&mode=dev
Rename
NoParameterstoInfoScreento utilize one component for both cases.https://www.figma.com/file/l7BAJAGICr10ELsSqQD0Sr/Design-System%3A-Desktop?node-id=13146%3A50213&mode=dev#757569773
close AUTH-264
[before]
[after]
Test Plan
make teardown-js && make setup-jsModule ControlsChangelog
Review requests
If you have any better name for the component, please let me know.
Risk assessment
low