Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer, step-generation): custom z offset for blowout #14793

Merged
merged 8 commits into from
Apr 4, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Apr 3, 2024

closes AUTH-7

Overview

This PR adds a custom z offset field to blowout in the advanced settings of mix and transfer

Test Plan

create a flex or Ot-2 protocol and add a transfer step. open the advanced settings and click on the blowout checkbox. The input field for z offset should be next to the location drop down. It should be disabled if the location is not chosen, or if the source/dest well is a trash bin/waste chute. Once it is enabled, click on it and it should render the tip position modal. The default should be 0 at the top of the well and then the range should be the depth of the well in a negative number. Add a custom offset and the step should be created successfully.

Now, do the same thing with a mix step.

Changelog

  • create a new field for blowout z offset
  • add new type to fields and step-generation
  • modify the tip position modal to account for the z offset starting from the top
  • fix the tests
  • fix cypress, the blowout commands now generate offset from the top of the well instead of from the bottom (this theoretically should NOT be a change in behavior since before, we were getting the z offset that was the height of the well from the bottom)

Review requests

see test plan

Risk assessment

low

@jerader jerader marked this pull request as ready for review April 3, 2024 19:50
@jerader jerader requested a review from a team as a code owner April 3, 2024 19:50
@jerader jerader requested review from a team, jbleon95, Elyorcv, koji and ncdiehl11 and removed request for a team April 3, 2024 19:50
@@ -1,8 +1,7 @@
import { uuid, getLabwareSlot } from '../../utils'
import { COLUMN_4_SLOTS } from '../../constants'
import * as errorCreators from '../../errorCreators'
import type { CreateCommand } from '@opentrons/shared-data'
import type { BlowoutParams } from '@opentrons/shared-data/protocol/types/schemaV3'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally migrated to using the latest schema for blowout props 😃

@jerader jerader requested a review from koji April 4, 2024 13:14
@koji
Copy link
Contributor

koji commented Apr 4, 2024

Screenshot 2024-04-04 at 9 22 20 AM

_well_height_label wouldn't need right: 10px

Screenshot 2024-04-04 at 9 24 50 AM

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sandbox worked as expected.
I just left one comment on modal's well height label position otherwise the changes look good to me.

@jerader
Copy link
Collaborator Author

jerader commented Apr 4, 2024

_well_height_label wouldn't need right: 10px

nice! thanks for catching this @koji. i'll remove it. seems like its some old css styling added 6 years ago 😅

@jerader jerader merged commit 048a533 into edge Apr 4, 2024
15 checks passed
@jerader jerader deleted the pd_z-blowout-offset branch April 4, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants