-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer, step-generation): custom z offset for blowout #14793
Conversation
@@ -1,8 +1,7 @@ | |||
import { uuid, getLabwareSlot } from '../../utils' | |||
import { COLUMN_4_SLOTS } from '../../constants' | |||
import * as errorCreators from '../../errorCreators' | |||
import type { CreateCommand } from '@opentrons/shared-data' | |||
import type { BlowoutParams } from '@opentrons/shared-data/protocol/types/schemaV3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally migrated to using the latest schema for blowout props 😃
protocol-designer/src/components/StepEditForm/fields/BlowoutZOffsetField.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/StepEditForm/fields/BlowoutZOffsetField.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/StepEditForm/fields/BlowoutZOffsetField.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/StepEditForm/fields/TipPositionField/TipPositionZAxisViz.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/StepEditForm/fields/TipPositionField/TipPositionZAxisViz.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/StepEditForm/fields/TipPositionField/TipPositionZAxisViz.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/StepEditForm/fields/TipPositionField/ZTipPositionModal.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/StepEditForm/fields/TipPositionField/ZTipPositionModal.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/StepEditForm/fields/__tests__/BlowoutZOffsetField.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sandbox worked as expected.
I just left one comment on modal's well height label position otherwise the changes look good to me.
nice! thanks for catching this @koji. i'll remove it. seems like its some old css styling added 6 years ago 😅 |
closes AUTH-7
Overview
This PR adds a custom z offset field to blowout in the advanced settings of mix and transfer
Test Plan
create a flex or Ot-2 protocol and add a transfer step. open the advanced settings and click on the blowout checkbox. The input field for z offset should be next to the location drop down. It should be disabled if the location is not chosen, or if the source/dest well is a trash bin/waste chute. Once it is enabled, click on it and it should render the tip position modal. The default should be 0 at the top of the well and then the range should be the depth of the well in a negative number. Add a custom offset and the step should be created successfully.
Now, do the same thing with a mix step.
Changelog
Review requests
see test plan
Risk assessment
low