Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app, components): fix parameter table styling #14809

Merged
merged 3 commits into from
Apr 5, 2024
Merged

fix(app, components): fix parameter table styling #14809

merged 3 commits into from
Apr 5, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Apr 4, 2024 •
edited
Loading

Overview

Fix styling for parameters table at both ProtocolDetails and ProtocolRunRunTimeParameters

Test Plan

  • upload RTP protocol which contains long display names or values
  • select protocol to observe ProtocolDetails
  • select 'Parameters' tab and resize window to view behavior of wrapped text/icons
Screenshot 2024-04-04 at 4 20 53 PM
  • begin protocol setup
  • select 'Parameters' tab and resize window to view behavior of wrapped text/icons
Screenshot 2024-04-04 at 4 21 31 PM

Changelog

  • make hoverable description icon inline with parameter display name, even if display name wraps to multiple lines
  • resize column widths according to designs

Review requests

authorship devs

Risk assessment

low

@ncdiehl
fix(app, components): fix parameter table styling
2edc1d1 
Fix styling for parameters table at both ProtocolDetails and ProtocolRunRunTimeParameters
@ncdiehl11 ncdiehl11 requested review from koji and jerader April 4, 2024 20:21
@ncdiehl11 ncdiehl11 marked this pull request as ready for review April 4, 2024 20:40
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner April 4, 2024 20:40
@ncdiehl11 ncdiehl11 requested a review from koji April 5, 2024 13:48
@ncdiehl11 ncdiehl11 requested a review from koji April 5, 2024 15:09
koji
koji approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ncdiehl11 ncdiehl11 merged commit 66b1a3b into edge Apr 5, 2024
46 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_style-parameter-tables branch April 5, 2024 16:54
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
@ncdiehl11 @Carlos-fernandez
fix(app, components): fix parameter table styling (#14809)
2d1a3f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

@jerader jerader Awaiting requested review from jerader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncdiehl11 @koji @ncdiehl