-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer): createFileWizard now accommodates MoaM for F… #14818
Conversation
let removeSlotForTrash = MODULES_SLOTS_FLEX | ||
if (trashBin != null && hasTC) { | ||
removeSlotForTrash = MODULES_SLOTS_FLEX.slice(0, -2) | ||
} else if (trashBin != null && !hasTC) { | ||
removeSlotForTrash = MODULES_SLOTS_FLEX.slice(0, -1) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is tricky because the way the logic works rn, the trash bin gets assigned in the parent component (CreateFileWizard
) which is down stream from when this util is called. Perhaps i need to add trashBin to its own field (not in additionalEquipment) to assign it a slot earlier.
I want to keep what i have though because that is a big refactor. if its giving us troubles, i'll have to refactor.
protocol-designer/src/components/modals/CreateFileWizard/EquipmentOption.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/modals/CreateFileWizard/EquipmentOption.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/modals/CreateFileWizard/EquipmentOption.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/modals/CreateFileWizard/EquipmentOption.tsx
Outdated
Show resolved
Hide resolved
numMultiples === 7 | ||
? undefined | ||
: () => { | ||
multiples.setValue(numMultiples + 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiples.setValue(numMultiples + 1) | |
multiples.setValue(prevNumMultiples => prevNumMultiples + 1) |
protocol-designer/src/components/modals/CreateFileWizard/EquipmentOption.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/modals/CreateFileWizard/EquipmentOption.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/modals/CreateFileWizard/EquipmentOption.tsx
Show resolved
Hide resolved
protocol-designer/src/components/modals/CreateFileWizard/EquipmentOption.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/modals/CreateFileWizard/ModulesAndOtherTile.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/modals/CreateFileWizard/utils.ts
Outdated
Show resolved
Hide resolved
protocol-designer/src/components/modals/CreateFileWizard/utils.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the sandbox worked as expected.
This new feature is really nice!
…lex temp
closes AUTH-15
Overview
Create file wizard now allows for multiple modules! The deck map is wired up but nothing else is wired up. There are no designs for this so I brainstormed with Nick a bit on ideas and messed around with existing components and came up with the following:
Screen.Recording.2024-04-05.at.13.48.55.mov
Test Plan
Enable the MoaM feature flag!
Create a flex protocol and mess around with adding/removing modules and staging area slots. Make sure things are disabled if there is no room on the deck.
The total amount of temperature modules should be 7 if there is nothing else on the deck. The up arrow should be disabled with a tooltip if there is no more space. The down arrow should be disabled if there are no temperature modules to get rid of.
I thoroughly tested this already and added a bunch of test coverage so hopefully it should work as expected but please call out anything that doesn't work!
Changelog
EquipmentOptions
and test to take into account having multiplesModulesAndOtherTile
to take into account having multiplesReview requests
see test plan
Risk assessment
low