-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(monorepo): update lint-js command #14977
Conversation
update lint-js command to speed up the linting process close AUTH-
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14977 +/- ##
==========================================
- Coverage 67.50% 62.63% -4.88%
==========================================
Files 2521 262 -2259
Lines 72090 14916 -57174
Branches 9311 0 -9311
==========================================
- Hits 48666 9342 -39324
+ Misses 21228 5574 -15654
+ Partials 2196 0 -2196
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot better for eslint
(first run is like 3-5 minutes, subsequent runs are 25 seconds) - enough that prettier --check
becomes the limiting factor. Let's merge this IMO
* refactor(monorepo): update lint-js command
Overview
update lint-js command to speed up the linting process
ESLint and Prettier can be run in parallel to reduce processing time. Using
pid
to handle commands parallelly.Add
--cache
https://eslint.org/blog/2015/09/eslint-v1.4.0-released/#cached-results
close AUTH-363
Test Plan
make lint-js
Changelog
Review requests
Risk assessment
low