Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(performance-metrics): separate storage logic from tracker #14979

Closed
wants to merge 9 commits into from

Conversation

DerekMaggio
Copy link
Contributor

@DerekMaggio DerekMaggio commented Apr 23, 2024

Overview

Closes https://opentrons.atlassian.net/browse/EXEC-415

  • Pulls out storage logic from tracker into MetricsStore object
  • Defines MetricsMetadata to store information about the MetricsStore object

Test Plan

  • Modified file storage test in performance-metrics to use the new classes.
    • Loads file content and validates it
  • Modified test_track_analysis test in api/test_cli
    • Loads file content and validates it

Changelog

  • Create MetricsMetadata in shared data which defines where to store data, what to call it, and the headers
  • Create MetricsStore which handles creating any necessary directories or files and then storing data to the files
  • Remove storage logic from RobotContextTracker then instantiate MetricsStore and call to its methods to handle data storage

Review requests

None

Risk assessment

Low

@DerekMaggio DerekMaggio marked this pull request as ready for review April 23, 2024 14:47
@DerekMaggio DerekMaggio requested a review from a team as a code owner April 23, 2024 14:47
@DerekMaggio DerekMaggio requested a review from a team April 23, 2024 14:47
@DerekMaggio DerekMaggio deleted the performance_metrics_data_store branch April 23, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant