fix(app): liquid detail fixed precision #15013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a couple places remaining where we presented liquid volumes but didn't have fixed precision, so we could have a pretty excessive number of decimals. Now those are all toFixed(1)'d. Also, there was an extra "total volume" label in some little grey-background-roundrect text objs in the liquid detail map view that would cause the background to clip behind the map. the label's not in the designs, so I pulled it. Closes RSQ-78
koji
approved these changes
Apr 25, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
There were a couple places remaining where we presented liquid volumes but didn't have fixed precision, so we could have a pretty excessive number of decimals. Now those are all toFixed(1)'d. Also, there was an extra "total volume" label in some little grey-background-roundrect text objs in the liquid detail map view that would cause the background to clip behind the map. the label's not in the designs, so I pulled it. Closes RSQ-78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple places remaining where we presented liquid volumes but didn't have fixed precision, so we could have a pretty excessive number of decimals. Now those are all toFixed(1)'d.
Also, there was an extra "total volume" label in some little grey-background-roundrect text objs in the liquid detail map view that would cause the background to clip behind the map. the label's not in the designs, so I pulled it.
Closes RSQ-78
Reviews and Testing
protocol preview liquid tab
new:
old:
run preview liquids list view with detail expansion
new:
old:
run preview liquids map view
new:
old:
Closes RSQ-78