Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): fix release notes #15023

Merged
merged 3 commits into from
Apr 26, 2024
Merged

fix(docs): fix release notes #15023

merged 3 commits into from
Apr 26, 2024

Conversation

y3rsh
Copy link
Member

@y3rsh y3rsh commented Apr 26, 2024

Keep experimenting with the formatting of the release notes

  • <br> was no good
  • trying headers

@y3rsh y3rsh requested review from a team as code owners April 26, 2024 13:01
@y3rsh y3rsh requested review from TamarZanzouri and removed request for a team April 26, 2024 13:01
@y3rsh y3rsh changed the title fix(docs): fix release notes 0 fix(docs): fix release notes Apr 26, 2024
DerekMaggio
DerekMaggio approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@DerekMaggio DerekMaggio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. Is the random link at the end supposed to be there? It produces a diff with no changes

Talked to Josh, the tag needs to be created for it to kick off a release for the link to show any changes So 100% all good now

@y3rsh y3rsh merged commit 001b1fa into [email protected] Apr 26, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekMaggio DerekMaggio DerekMaggio approved these changes

@TamarZanzouri TamarZanzouri Awaiting requested review from TamarZanzouri TamarZanzouri is a code owner automatically assigned from Opentrons/js

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y3rsh @DerekMaggio