refactor(app): refine useNotifyService #15093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useNotifyService leaks refetch frequencies unnecessarily. We can refactor this logic to useNotifyService.
mjhuff
commented
May 6, 2024
There was a problem hiding this comment.
IDK how this test was passing before, but it correctly broke now. I've mocked it in the expected way, and it passes.
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
useNotifyService leaks refetch frequencies unnecessarily. We can refactor this logic to useNotifyService where it belongs and tighten the abstraction.
Carlos-fernandez
pushed a commit
that referenced
this pull request
Jun 3, 2024
useNotifyService leaks refetch frequencies unnecessarily. We can refactor this logic to useNotifyService where it belongs and tighten the abstraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
useNotifyService leaks refetch frequencies unnecessarily. We can refactor this logic to useNotifyService where it belongs and tighten the abstraction.
Test Plan
Risk assessment
low