refactor(app, api-client, shared-data): Set command intent to "fixit" #15119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to support FIXIT commands useChainRunCommands takes an optional parameter, the failedCommandId, and implictly sends a command with a FIXIT intent if present.
sfoster1
approved these changes
May 7, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
…#15119) Closes EXEC-431 Before we can POST fixit commands during Error Recovery flows, we need to refactor useChainRunCommands to support sending the params necessary to POST a fixit command. In addition to a normal CreateCommand, this requires sending: * A failedCommandId * An explicit fixit intent
Carlos-fernandez
pushed a commit
that referenced
this pull request
Jun 3, 2024
…#15119) Closes EXEC-431 Before we can POST fixit commands during Error Recovery flows, we need to refactor useChainRunCommands to support sending the params necessary to POST a fixit command. In addition to a normal CreateCommand, this requires sending: * A failedCommandId * An explicit fixit intent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EXEC-431
Overview
Before we can POST fixit commands during Error Recovery flows, we need to refactor
useChainRunCommandsto support sending the params necessary to POST a fixit command. In addition to a normalCreateCommand, this requires sending:failedCommandIdfixitintentBecause the FE never explicitly sets
intentin the app until now, it feels correct to keep theintent: fixitlogic abstracted when creating a new command from the app. Open to thoughts/comments/concerns.Test Plan
Review requests
Are the
shared-datatypes changes correct?Risk assessment
low