-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(app, api-client, react-api-client): unify analysis and run record for CommandText use #15125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecord for CommandText use After a run is terminal, we access the run record rather than the most recently completed analysis in the command list in the run preview (or more aptly, run postview). This PR refactors the data sent to CommandText and ultimately many of its children and utilities to include only the necessary data from the run record if the run is terminal, or the most recent analysis if the run has not started or is in progress.
jerader
reviewed
May 8, 2024
jerader
reviewed
May 8, 2024
jerader
reviewed
May 8, 2024
jerader
reviewed
May 8, 2024
app/src/organisms/OnDeviceDisplay/RunningProtocol/CurrentRunningProtocolCommand.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
May 8, 2024
…g commandTextData
koji
reviewed
May 8, 2024
koji
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes look good to me.
thank you for refactoring!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-380
Overview
After a run is terminal, we access the run record rather than the most recently completed analysis in the command list in the run preview (or more aptly, run postview). This PR refactors the data sent to CommandText and ultimately many of its children and utilities to include only the necessary data from the run record if the run is terminal, or the most recent analysis if the run has not started or is in progress.
Test Plan
rtp_tests.py
here)Changelog
add new interface
CommandTextData
specifying the following subset of the union ofCompletedProtocolAnalysis
andLegacyGoodRunData
implement this new interface in
CommandText
, its child components covering all possible command types, and its utilities that lookup entity data from their respective load commandsReview requests
auth js
Risk assessment
low-medium