fix (abr-testing): Checks that most recent run is completed in abr_scale script #15661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
requested changes
Jul 15, 2024
| try: | ||
| num_of_runs_added = len(runs_and_robots) | ||
| print(f"{num_of_runs_added} run(s) added.") | ||
| except UnboundLocalError: |
There was a problem hiding this comment.
this is usually not an exception you want to be catching. Maybe make runs_and_robots optionally None instead and always exist?
There was a problem hiding this comment.
runs_and_robots is defined at the beginning so i think i can get rid of the error handling
rclarke0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Checks that run being pulled is completed. Adds error handling if no new runs need to be added.
Test Plan
Changelog
Review requests
Risk assessment