Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hardware): didn't mean to take this out #15770

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

ryanthecoder
Copy link
Contributor

@ryanthecoder ryanthecoder commented Jul 23, 2024

Overview

We had removed this as part of another PR aimed at reducing magic numbers and put it in ot3api, but then that caused a circular dependency problem and we reverted. we just missed this line when we reverted

Test Plan

Changelog

Review requests

Risk assessment

@ryanthecoder ryanthecoder requested a review from a team as a code owner July 23, 2024 18:35
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (once reformatted)

@ryanthecoder ryanthecoder requested a review from a team as a code owner July 23, 2024 19:14
@ryanthecoder ryanthecoder merged commit e0e018f into edge Jul 23, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants