feat(robot-server): split database into v5 and v6 #15818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sanni-t
force-pushed
the
split-database-into-v5-and-v6
branch
from
5a99d3a to
b71f9b5
Compare
SyntaxColoring
approved these changes
Jul 29, 2024
|
Oh and also the directory of data files themselves? I’m on my phone and having trouble bouncing around the code, but it looks like the file contents live outside the table? |
Yep! Thanks for catching that! |
SyntaxColoring
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Splits up the changes we have so far into a v5 schema that's already in QA and anything on top of that to be in v6 so that QA & ABR don't have to do database resets while testing.
This branch is currently pointing to edge that has the v5 schema that's in QA. This is done on purpose so that we can check that the database changes diff between current edge (without v5.1) and introduction of v6 is correct and is not affected by the intermediate v5.1 DB changes.
Only look at the changes in the persistence directory (and its tests). Everything else is part of the outstanding PRs that introduced v5.1 changes and is irrelevant to the matter at hand.
Will rebase the changes onto edge once edge has the 5.1 changes.