Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Actually ignore errors that are marked as ignorable #15850

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

SyntaxColoring
Copy link
Contributor

Overview

Closes EXEC-634.

Test Plan and Hands on Testing

@mjhuff and I tested this in combination with his frontend work.

Review requests

None.

Risk assessment

Low.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner July 31, 2024 16:07
@SyntaxColoring SyntaxColoring requested a review from a team July 31, 2024 16:07
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@SyntaxColoring SyntaxColoring changed the title fix(api): Actually ignore errors that fix(api): Actually ignore errors that are marked as ignorable Jul 31, 2024
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, makes sense

@SyntaxColoring SyntaxColoring merged commit 8739d72 into edge Jul 31, 2024
21 checks passed
@SyntaxColoring SyntaxColoring deleted the actually_ignore_errors branch July 31, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants