Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): emptySelectorButton creation #15958

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Aug 9, 2024

closes AUTH-621

Overview

Create the empty selector button, story, and test

Test Plan and Hands on Testing

view the storybook and make sure it matches the designs.

Changelog

create new component and story and test

Review requests

see test plan

Risk assessment

low

@jerader jerader requested a review from a team as a code owner August 9, 2024 19:50
@jerader jerader requested review from shlokamin, koji and ncdiehl11 and removed request for a team August 9, 2024 19:50
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of comments
checked EmptySelectroButton on Storybook and it looked good!

@jerader jerader merged commit ad93c30 into edge Aug 12, 2024
48 checks passed
@jerader jerader deleted the components_emptySelectorButton branch August 12, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants