fix(api): Lld end z retract position bug #15960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthecoder
force-pushed
the
lld-end-z-retract-position-bug
branch
from
2838283 to
f4b0c4f
Compare
| top_types.Point(*self._config.gripper_mount_offset), | ||
| ) | ||
| cp = self.critical_point_for(mount, None) | ||
| return deck_end_z + offset[2] + cp.z |
There was a problem hiding this comment.
nitpick: I think offset.z is a little clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The Z is supposed to retract out to the liquid before sending over the buffered data, however a line from testing got merged in there and this wasn't happening. Also had to fixup the api side since it was calculating the liquid height based off where the machine position was after hardware control took over, now it actually uses the return value to that it returns, converts it to deck coordinates and applies the corresponding offsets.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment